Handle clients-tests requires section #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setup_steps = test_step | ||
| elif test_name == "teardown": | ||
| teardown_steps = test_step | ||
| else: | ||
| test_numbers_and_steps.append((test_number, test_step)) | ||
| test_number += 1 | ||
|
|
||
| if not requires["serverless"]: |
There was a problem hiding this comment.
Can a test not have a requires section, or have it, but not have a serverless key in it? Not sure if that is possible, but I think it would make sense to protect against a crash here.
There was a problem hiding this comment.
It's not possible. If it happens, I'd rather crash loudly than making a wrong choice (offensive programming vs. defensive programming). After all, we fully control the tests here.
| @@ -568,20 +568,25 @@ def remove_implicit_resolver(cls, tag_to_remove): | |||
| # Each file may have a "test" named 'setup' or 'teardown', | |||
There was a problem hiding this comment.
This comment should also mention the requires section.
There was a problem hiding this comment.
Thanks, addressed in 545a1cc (#48)
miguelgrinberg
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an example YAML file https://github.com/elastic/elasticsearch-clients-tests/blob/main/tests/ping/ping.yml. The "requires" sections were mistaken for actual tests to run until now.