removing newlines + unit test

Author: l-trotta

compiler-rs/clients_schema_to_openapi/src/paths.rs

@@ -317,8 +317,10 @@ fn get_path_parameters(template: &str) -> Vec<&str> {
 fn split_summary_desc(desc: &str) -> SplitDesc{
     let segmenter = SentenceSegmenter::new();
 
+    let desc_no_newlines = desc.replace('\n'," ");
+
     let breakpoints: Vec<usize> = segmenter
-        .segment_str(desc)
+        .segment_str(&desc_no_newlines)
         .collect();
 
     if breakpoints.len()<2{
@@ -327,15 +329,16 @@ fn split_summary_desc(desc: &str) -> SplitDesc{
             description: None
         }
     }
-    let first_line = &desc[breakpoints[0]..breakpoints[1]];
-    let rest = &desc[breakpoints[1]..breakpoints[breakpoints.len()-1]];
+    let first_line = &desc_no_newlines[breakpoints[0]..breakpoints[1]];
+    let rest = &desc_no_newlines[breakpoints[1]..breakpoints[breakpoints.len()-1]];
 
     SplitDesc {
-        summary:  Option::from(String::from(first_line.trim().strip_suffix('.').unwrap_or(first_line))),
-        description: if !rest.is_empty() {Option::from(String::from(rest.trim()))} else {None}
+        summary:  Some(String::from(first_line.trim().strip_suffix('.').unwrap_or(first_line))),
+        description: if !rest.is_empty() {Some(String::from(rest.trim()))} else {None}
     }
 }
 
+#[derive(PartialEq,Debug)]
 struct SplitDesc {
     summary: Option<String>,
     description: Option<String>
@@ -355,4 +358,28 @@ mod tests {
         assert_eq!(get_path_parameters("{index}{id/"), vec! {"index"});
         assert_eq!(get_path_parameters("{index{id}/"), vec! {"index{id"});
     }
+
+    #[test]
+    fn test_split_summary_desc() {
+        assert_eq!(split_summary_desc("One sentence."),
+                   SplitDesc{
+                       summary: Some(String::from("One sentence")),
+                       description: None
+                   });
+        assert_eq!(split_summary_desc("This is\nstill one. sentence: all; together"),
+                   SplitDesc{
+                       summary: Some(String::from("This is still one. sentence: all; together")),
+                       description: None
+                   });
+        assert_eq!(split_summary_desc("These are two totally. Separate sentences!"),
+                   SplitDesc{
+                       summary: Some(String::from("These are two totally")),
+                       description: Some(String::from("Separate sentences!"))
+                   });
+        assert_eq!(split_summary_desc(""),
+                   SplitDesc{
+                       summary: None,
+                       description: None
+                   });
+    }
 }

compiler-rs/compiler-wasm-lib/pkg/compiler_wasm_lib_bg.wasm

@@ -3800,8 +3800,7 @@
         "tags": [
           "cluster.pending_tasks"
         ],
-        "summary": "Returns a list of any cluster-level changes (e.g. create index, update mapping,\n",
-        "description": "allocate or fail shard) which have not yet been executed.",
+        "summary": "Returns a list of any cluster-level changes (e.g. create index, update mapping, allocate or fail shard) which have not yet been executed",
         "externalDocs": {
           "url": "https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-pending.html"
         },
@@ -14021,8 +14020,7 @@
         "tags": [
           "indices.rollover"
         ],
-        "summary": "Updates an alias to point to a new index when the existing index\n",
-        "description": "is considered to be too large or too old.",
+        "summary": "Updates an alias to point to a new index when the existing index is considered to be too large or too old",
         "externalDocs": {
           "url": "https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-rollover-index.html"
         },
@@ -14059,8 +14057,7 @@
         "tags": [
           "indices.rollover"
         ],
-        "summary": "Updates an alias to point to a new index when the existing index\n",
-        "description": "is considered to be too large or too old.",
+        "summary": "Updates an alias to point to a new index when the existing index is considered to be too large or too old",
         "externalDocs": {
           "url": "https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-rollover-index.html"
         },
@@ -24716,8 +24713,7 @@
         "tags": [
           "reindex"
         ],
-        "summary": "Allows to copy documents from one index to another, optionally filtering the source\n",
-        "description": "documents by a query, changing the destination index settings, or fetching the\ndocuments from a remote cluster.",
+        "summary": "Allows to copy documents from one index to another, optionally filtering the source documents by a query, changing the destination index settings, or fetching the documents from a remote cluster",
         "externalDocs": {
           "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/docs-reindex.html"
         },
@@ -34733,7 +34729,7 @@
           "update_by_query"
         ],
         "summary": "Updates documents that match the specified query",
-        "description": "If no query is specified,\n performs an update on every document in the index without changing the source,\nfor example to pick up a mapping change.",
+        "description": "If no query is specified,  performs an update on every document in the index without changing the source, for example to pick up a mapping change.",
         "externalDocs": {
           "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/docs-update-by-query.html"
         },