Skip to content

Commit 664b6d6

Browse files
committed
Stop reporting missing endpoints as errors
We have other ways of identifying them.
1 parent b55d29e commit 664b6d6

File tree

2 files changed

+2
-65
lines changed

2 files changed

+2
-65
lines changed

compiler/src/steps/validate-model.ts

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -215,14 +215,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
215215
return
216216
}
217217

218-
if (endpoint.request == null) {
219-
if (endpoint.response == null) {
220-
modelError('Missing request & response')
221-
return
222-
} else {
223-
modelError('Missing request')
224-
}
225-
} else {
218+
if (endpoint.request !== null) {
226219
const reqType = getTypeDef(endpoint.request)
227220

228221
if (reqType == null) {
@@ -266,9 +259,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
266259

267260
setRootContext(endpoint.name, 'response')
268261

269-
if (endpoint.response == null) {
270-
modelError('Missing response')
271-
} else {
262+
if (endpoint.response !== null) {
272263
const respType = getTypeDef(endpoint.response)
273264

274265
if (respType == null) {

output/schema/validation-errors.json

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
],
77
"response": []
88
},
9-
"capabilities": {
10-
"request": [
11-
"Missing request & response"
12-
],
13-
"response": []
14-
},
159
"cluster.get_component_template": {
1610
"request": [
1711
"Request: query parameter 'flat_settings' does not exist in the json spec"
@@ -24,30 +18,6 @@
2418
],
2519
"response": []
2620
},
27-
"connector.secret_delete": {
28-
"request": [
29-
"Missing request & response"
30-
],
31-
"response": []
32-
},
33-
"connector.secret_get": {
34-
"request": [
35-
"Missing request & response"
36-
],
37-
"response": []
38-
},
39-
"connector.secret_post": {
40-
"request": [
41-
"Missing request & response"
42-
],
43-
"response": []
44-
},
45-
"connector.secret_put": {
46-
"request": [
47-
"Missing request & response"
48-
],
49-
"response": []
50-
},
5121
"create": {
5222
"request": [
5323
"Request: query parameter 'if_primary_term' does not exist in the json spec",
@@ -74,24 +44,6 @@
7444
],
7545
"response": []
7646
},
77-
"fleet.delete_secret": {
78-
"request": [
79-
"Missing request & response"
80-
],
81-
"response": []
82-
},
83-
"fleet.get_secret": {
84-
"request": [
85-
"Missing request & response"
86-
],
87-
"response": []
88-
},
89-
"fleet.post_secret": {
90-
"request": [
91-
"Missing request & response"
92-
],
93-
"response": []
94-
},
9547
"get_source": {
9648
"request": [
9749
"Request: query parameter 'stored_fields' does not exist in the json spec"
@@ -248,12 +200,6 @@
248200
],
249201
"response": []
250202
},
251-
"transform.get_node_stats": {
252-
"request": [
253-
"Missing request & response"
254-
],
255-
"response": []
256-
},
257203
"transform.get_transform": {
258204
"request": [],
259205
"response": [

0 commit comments

Comments
 (0)