Fixing cluster stats response (#4632)

* fixing cluster stats response

* addressing review with more fixes

* update healthstatus enums

* addressing review

* add fielddata, more comments

* fix type dense vector fields

* fixed raw values not nullable

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>

Author: l-trotta

specification/_global/health_report/types.ts

@@ -26,7 +26,8 @@ export enum IndicatorHealthStatus {
   green,
   yellow,
   red,
-  unknown
+  unknown,
+  unavailable
 }
 
 export class Indicators {

specification/_types/Stats.ts

@@ -109,13 +109,35 @@ export class DocStats {
    * Elasticsearch reclaims the disk space of deleted Lucene documents when a segment is merged.
    */
   deleted?: long
+  /**
+   * Returns the total size in bytes of all documents in this stats.
+   * This value may be more reliable than store_stats.size_in_bytes in estimating the index size.
+   */
+  total_size_in_bytes: long
+  /**
+   * Human readable total_size_in_bytes
+   */
+  total_size?: ByteSize
 }
 
 export class FielddataStats {
   evictions?: long
   memory_size?: ByteSize
   memory_size_in_bytes: long
   fields?: Dictionary<Field, FieldMemoryUsage>
+  global_ordinals: GlobalOrdinalsStats
+}
+
+export class GlobalOrdinalsStats {
+  build_time_in_millis: UnitMillis
+  build_time?: string
+  fields?: Dictionary<Name, GlobalOrdinalFieldStats>
+}
+
+export class GlobalOrdinalFieldStats {
+  build_time_in_millis: UnitMillis
+  build_time?: string
+  shard_max_value_count: long
 }
 
 export class FieldMemoryUsage {
@@ -307,7 +329,6 @@ export class SegmentsStats {
    * Total amount of memory used by all index writers across all shards assigned to selected nodes.
    */
   index_writer_memory?: ByteSize
-  index_writer_max_memory_in_bytes?: long
   /**
    * Total amount, in bytes, of memory used by all index writers across all shards assigned to selected nodes.
    */
@@ -340,11 +361,14 @@ export class SegmentsStats {
    * Total amount, in bytes, of memory used for points across all shards assigned to selected nodes.
    */
   points_memory_in_bytes: long
-  stored_memory?: ByteSize
   /**
    * Total amount, in bytes, of memory used for stored fields across all shards assigned to selected nodes.
    */
   stored_fields_memory_in_bytes: long
+  /**
+   * Total amount of memory used for stored fields across all shards assigned to selected nodes.
+   */
+  stored_fields_memory?: ByteSize
   /**
    * Total amount, in bytes, of memory used for terms across all shards assigned to selected nodes.
    */
@@ -356,7 +380,7 @@ export class SegmentsStats {
   /**
    * Total amount of memory used for term vectors across all shards assigned to selected nodes.
    */
-  term_vectory_memory?: ByteSize
+  term_vectors_memory?: ByteSize
   /**
    * Total amount, in bytes, of memory used for term vectors across all shards assigned to selected nodes.
    */

specification/_types/common.ts

@@ -232,7 +232,9 @@ export enum HealthStatus {
    * One or more primary shards are unassigned, so some data is unavailable. This can occur briefly during cluster startup as primary shards are assigned.
    * @aliases RED
    */
-  red
+  red,
+  unknown,
+  unavailable
 }
 
 export enum HttpMethod {

specification/cluster/stats/ClusterStatsResponse.ts

@@ -20,7 +20,13 @@
 import { HealthStatus, Name, Uuid } from '@_types/common'
 import { long } from '@_types/Numeric'
 import { NodesResponseBase } from '@nodes/_types/NodesResponseBase'
-import { CCSStats, ClusterIndices, ClusterNodes } from './types'
+import { Dictionary } from '@spec_utils/Dictionary'
+import {
+  CCSStats,
+  ClusterIndices,
+  ClusterNodes,
+  ClusterSnapshotStats
+} from './types'
 
 export class StatsResponseBase extends NodesResponseBase {
   /**
@@ -40,10 +46,18 @@ export class StatsResponseBase extends NodesResponseBase {
    * @doc_id cluster-nodes
    */
   nodes: ClusterNodes
+  /**
+   * Contains stats on repository feature usage exposed in cluster stats for telemetry.
+   */
+  repositories: Dictionary<Name, Dictionary<Name, long>>
+  /**
+   * Contains stats cluster snapshots.
+   */
+  snapshots: ClusterSnapshotStats
   /**
    * Health status of the cluster, based on the state of its primary and replica shards.
    */
-  status: HealthStatus
+  status?: HealthStatus
   /**
    * Unix timestamp, in milliseconds, for the last time the cluster statistics were refreshed.
    */