Skip to content

Commit fcc4833

Browse files
committed
Address review feedback
1 parent 952436e commit fcc4833

16 files changed

+386
-407
lines changed

output/openapi/elasticsearch-serverless-openapi.json

Lines changed: 281 additions & 281 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/schema/schema.json

Lines changed: 18 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/typescript/types.ts

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/_json_spec/connector.sync_job_cancel.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,13 @@
77
"stability": "experimental",
88
"visibility": "public",
99
"headers": {
10-
"accept": [
11-
"application/json"
12-
]
10+
"accept": ["application/json"]
1311
},
1412
"url": {
1513
"paths": [
1614
{
1715
"path": "/_connector/_sync_job/{connector_sync_job_id}/_cancel",
18-
"methods": [
19-
"PUT"
20-
],
16+
"methods": ["PUT"],
2117
"parts": {
2218
"connector_sync_job_id": {
2319
"type": "string",

specification/_json_spec/connector.sync_job_delete.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,13 @@
77
"stability": "experimental",
88
"visibility": "public",
99
"headers": {
10-
"accept": [
11-
"application/json"
12-
]
10+
"accept": ["application/json"]
1311
},
1412
"url": {
1513
"paths": [
1614
{
1715
"path": "/_connector/_sync_job/{connector_sync_job_id}",
18-
"methods": [
19-
"DELETE"
20-
],
16+
"methods": ["DELETE"],
2117
"parts": {
2218
"connector_sync_job_id": {
2319
"type": "string",

specification/_json_spec/connector.sync_job_get.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,13 @@
77
"stability": "experimental",
88
"visibility": "public",
99
"headers": {
10-
"accept": [
11-
"application/json"
12-
]
10+
"accept": ["application/json"]
1311
},
1412
"url": {
1513
"paths": [
1614
{
1715
"path": "/_connector/_sync_job/{connector_sync_job_id}",
18-
"methods": [
19-
"GET"
20-
],
16+
"methods": ["GET"],
2117
"parts": {
2218
"connector_sync_job_id": {
2319
"type": "string",

specification/_json_spec/connector.sync_job_list.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,13 @@
77
"stability": "experimental",
88
"visibility": "public",
99
"headers": {
10-
"accept": [
11-
"application/json"
12-
]
10+
"accept": ["application/json"]
1311
},
1412
"url": {
1513
"paths": [
1614
{
1715
"path": "/_connector/_sync_job",
18-
"methods": [
19-
"GET"
20-
]
16+
"methods": ["GET"]
2117
}
2218
]
2319
},

specification/_json_spec/connector.sync_job_post.json

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,14 @@
77
"stability": "experimental",
88
"visibility": "public",
99
"headers": {
10-
"accept": [
11-
"application/json"
12-
],
13-
"content_type": [
14-
"application/json"
15-
]
10+
"accept": ["application/json"],
11+
"content_type": ["application/json"]
1612
},
1713
"url": {
1814
"paths": [
1915
{
2016
"path": "/_connector/_sync_job",
21-
"methods": [
22-
"POST"
23-
]
17+
"methods": ["POST"]
2418
}
2519
]
2620
},

specification/connector/_types/SyncJob.ts

Lines changed: 34 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -16,55 +16,56 @@
1616
* specific language governing permissions and limitations
1717
* under the License.
1818
*/
19-
import { Id } from "@_types/common";
20-
import { long } from "@_types/Numeric";
21-
import { Dictionary } from "@spec_utils/Dictionary";
22-
import { UserDefinedValue } from "@spec_utils/UserDefinedValue";
19+
import { Id } from '@_types/common'
20+
import { long } from '@_types/Numeric'
21+
import { DateTime } from '@_types/Time'
22+
import { Dictionary } from '@spec_utils/Dictionary'
23+
import { UserDefinedValue } from '@spec_utils/UserDefinedValue'
2324
import {
2425
ConnectorConfiguration,
2526
FilteringConfig,
2627
IngestPipelineParams,
27-
SyncStatus,
28-
} from "./Connector";
28+
SyncStatus
29+
} from './Connector'
2930

3031
interface SyncJobConnectorReference {
31-
configuration: ConnectorConfiguration;
32-
filtering: FilteringConfig;
33-
id: Id;
34-
index_name: string;
35-
language?: string;
36-
pipeline: IngestPipelineParams;
37-
service_type: string;
32+
configuration: ConnectorConfiguration
33+
filtering: FilteringConfig
34+
id: Id
35+
index_name: string
36+
language?: string
37+
pipeline?: IngestPipelineParams
38+
service_type: string
3839
}
3940

4041
enum SyncJobType {
4142
full,
4243
incremental,
43-
access_control,
44+
access_control
4445
}
4546

4647
enum TriggerMethod {
4748
on_demand,
48-
scheduled,
49+
scheduled
4950
}
5051

5152
export interface ConnectorSyncJob {
52-
cancelation_requested_at?: string;
53-
canceled_at?: string;
54-
completed_at?: string;
55-
connector: SyncJobConnectorReference;
56-
created_at: string;
57-
deleted_document_count: long;
58-
error?: string;
59-
id: Id;
60-
indexed_document_count: long;
61-
indexed_document_volume: long;
62-
job_type: SyncJobType;
63-
last_seen?: string;
64-
metadata: Dictionary<string, UserDefinedValue>;
65-
started_at?: string;
66-
status: SyncStatus;
67-
total_document_count?: long;
68-
trigger_method: TriggerMethod;
69-
worker_hostname?: string;
53+
cancelation_requested_at?: DateTime
54+
canceled_at?: DateTime
55+
completed_at?: DateTime
56+
connector: SyncJobConnectorReference
57+
created_at: DateTime
58+
deleted_document_count: long
59+
error?: string
60+
id: Id
61+
indexed_document_count: long
62+
indexed_document_volume: long
63+
job_type: SyncJobType
64+
last_seen?: DateTime
65+
metadata: Dictionary<string, UserDefinedValue>
66+
started_at?: DateTime
67+
status: SyncStatus
68+
total_document_count: long
69+
trigger_method: TriggerMethod
70+
worker_hostname?: string
7071
}

specification/connector/sync_job_cancel/SyncJobCancelRequest.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
* specific language governing permissions and limitations
1717
* under the License.
1818
*/
19-
import { RequestBase } from "@_types/Base";
20-
import { Id } from "@_types/common";
19+
import { RequestBase } from '@_types/Base'
20+
import { Id } from '@_types/common'
2121

2222
/**
2323
* Cancels a connector sync job.
@@ -31,6 +31,6 @@ export interface Request extends RequestBase {
3131
/**
3232
* The unique identifier of the connector sync job
3333
*/
34-
connector_sync_job_id: Id;
35-
};
34+
connector_sync_job_id: Id
35+
}
3636
}

specification/connector/sync_job_delete/SyncJobDeleteRequest.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
* specific language governing permissions and limitations
1717
* under the License.
1818
*/
19-
import { RequestBase } from "@_types/Base";
20-
import { Id } from "@_types/common";
19+
import { RequestBase } from '@_types/Base'
20+
import { Id } from '@_types/common'
2121

2222
/**
2323
* Deletes a connector sync job.
@@ -31,6 +31,6 @@ export interface Request extends RequestBase {
3131
/**
3232
* The unique identifier of the connector sync job to be deleted
3333
*/
34-
connector_sync_job_id: Id;
35-
};
34+
connector_sync_job_id: Id
35+
}
3636
}

0 commit comments

Comments
 (0)