Add missing shard_min_doc_count to TermsAggregation#2175
Add missing shard_min_doc_count to TermsAggregation#2175pquentin merged 4 commits intoelastic:mainfrom
Conversation
|
Made it similar to elastic/elasticsearch-java#319. Ideally, I would like to get this new field in the java client, but I am not sure if this is enough. |
|
Pinging @Anaethelion, @davidkyle and @flobernd. |
pquentin
left a comment
There was a problem hiding this comment.
I checked that this is the only bucket aggregation that's should have shard_min_doc_count but is missing it.
|
Hi @pquentin, thanks for looking into this! |
|
@rand0m86 it will be in the next version, sorry for the long wait |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2175-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2bb4d0cc61ca56099a1dd4e1dee4bdb1bf7e4362
# Push it to GitHub
git push --set-upstream origin backport-2175-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17Then, create a pull request where the |
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 2bb4d0c)
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 2bb4d0c)
Adding missing
shard_min_doc_countfield to terms aggregation.Closes #2631