Skip to content

Add missing sum_other_doc_count to TermsAggregation #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add missing sum_other_doc_count to TermsAggregation #2183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d875a4
shard_min_doc_count,sum_other_doc_count missing from Terms Aggregatio…
tyrantkhan Jul 15, 2023
0c6965f
Merge remote-tracking branch 'origin/main' into update-terms-aggregat…
pquentin Jun 21, 2024
b5bfab4
Revert accidental dangling.csv move
pquentin Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 26 additions & 14 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions specification/_types/aggregations/bucket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,6 +968,13 @@ export class TermsAggregation extends BucketAggregationBase {
* Set to `true` to return the `doc_count_error_upper_bound`, which is an upper bound to the error on the `doc_count` returned by each shard.
*/
show_term_doc_count_error?: boolean
/**
* The number of documents that didn't make it into the the top size terms.
* If this is greater than 0, the terms agg had to throw away some buckets, either because they
* didn't fit into size on the coordinating node or they didn't fit into shard_size on the data
* node.
*/
sum_other_doc_count?: integer
/**
* The number of buckets returned out of the overall terms list.
* @server_default 10
Expand Down
Loading