Add null value and Setting type #2478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
NullValue
type that is an alias tonull
, meant to represent "meaningful" null values, i.e. nulls that are not equivalent to missing value.It also introduces a
Settings
type that represent a setting. Elasticsearch handles settings in very specific ways:null
resets the setting to its default valueThis PR does not uses these new types and value in the API specification. They first need to be implemented in code generators where relevant (a separate issue will track this).
Fixes #2049 - from the proposals in this issue, we introduce a specific type for meaningful nulls, but keep the standard typescript
null
for "null as optional".