Make k and num_candidates optional in kNN queries #2490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The validation results appear to be worse than what we have on main currently, so I will investigate. |
swallez
previously requested changes
Apr 8, 2024
There was a problem hiding this comment.
KnnSearch is good, but there are some discrepancies on KnnQuery:
- it must extend
QueryBaseto have the_nameandboostfields (the latter should be removed from the type) num_candidatesshould be optionalkandinner_hitsshould be removed.
Can you add these fixes?
pquentin
force-pushed
the
k-num-candidates-optional
branch
from
8fb436a to
c07ed5e
Compare
|
Thanks, done! The CI failure is addressed in #2492. |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
l-trotta
approved these changes
Apr 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Make k and num_candidates optional in kNN queries * Address review comments (cherry picked from commit 4718254)
pquentin
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects the changes made in 8.13: elastic/elasticsearch#101209. The current situation forces setting values: https://discuss.elastic.co/t/knnquery-in-java-client/356645/1