-
Notifications
You must be signed in to change notification settings - Fork 98
API specification changes for custom roles #2491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@elasticmachine update branch |
…astic/elasticsearch-specification into custom-roles-api-spec-changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left one comment about MONITOR_TEXT_STRUCTURE.
I checked with @Anaethelion that the validation did not change locally without the enum changes, so the failures are not related to this PR.
Would you mind opening a follow-up pull request to add the missing ClusterPrivilege
(like NONE
or MANAGE_BEHAVIORAL_ANALYTICS
) and IndexPrivilege
(like MANAGE_DATA_STREAM_LIFECYCLE
or CROSS_CLUSTER_REPLICATION
) values? I suppose it can go in this one too, if you prefer.
For sure. I'll make it a separate PR because we can make these changes now already, whereas the current PR will have to wait until the Serverless-side API changes are ready to be made public. |
…astic/elasticsearch-specification into custom-roles-api-spec-changes
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Brings back #2491 with a few corrected annotations. The changes included in this PR are ready to be published: the privileges pertain to the API key APIs which are already public in Serverless. However, the visibility of the Create or Update Roles API (as well as other Role-related APIs) remains private until the feature is ready. I will open a separate PR for those when the time has come.
With changes for Serverless custom roles, several roles-related APIs have stricter request validation. This PR codifies these requirements into our ES API specification.
Notes & questions to reviewers:
Closes: ES-7833