Add esql version #2512
Add esql version #2512
Conversation
Adds a `version` parameter to the ESQL `_query` request endpoint. We'll do some work to give this a default value in the generated clients soon, but for 8.14+ this'll be a required parameter.
I'm running: and it's been half an hour or so installing a flight recorder. |
There was a problem hiding this comment.
Can't comment on how this affects clients etc., but I checked/proofread the contained docs.
Thanks a lot @nik9000 !
Only reservation I have is whether official specs should already document "version": "snapshot", which is intended for testing purposes only.
| "name": "2024.04.01" | ||
| }, | ||
| { | ||
| "description": "Run against the unreleased version of the ESQL language. This will\ncontain any changes staged for release that have yet to be included\nin a version.", |
There was a problem hiding this comment.
IMHO we should mention that this only works on SNAPSHOT builds. ES on non-SNAPSHOT builds will return a 400 if it sees "version": "snapshot".
I wonder if we should even make snapshot a part of the official specs - it's not like users miss out if they cannot use language feature xyz, given that existing language versions are going to still be updated with new features.
Can we maybe add snapshot here later, if it turns out that there's an important enough use case for it?
| query: string | ||
| query: string, | ||
| /** | ||
| * The version of the ES|QL language in which the "query" field uses was written. |
There was a problem hiding this comment.
| * The version of the ES|QL language in which the "query" field uses was written. | |
| * The version of the ES|QL language in which the "query" field was written. |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
fyi: I created this workflow a while ago which automatically takes care of generating- and pushing the output json, if it is not part of the PR. This makes including the output json optional 🙂 It was primarily done to allow users to contribute without setting up Node etc., but might as well save some time for everybody else. |
|
Cool! I've just merged. Let me know if we need anything else around version~ |
Adds a `version` parameter to the ESQL `_query` request endpoint. We'll do some work to give this a default value in the generated clients soon, but for 8.14+ this'll be a required parameter. --------- Co-authored-by: Alexander Spies <alexander.spies@elastic.co> (cherry picked from commit 947a1ea)
Adds a `version` parameter to the ESQL `_query` request endpoint. We'll do some work to give this a default value in the generated clients soon, but for 8.14+ this'll be a required parameter. --------- Co-authored-by: Alexander Spies <alexander.spies@elastic.co> (cherry picked from commit 947a1ea) Co-authored-by: Nik Everett <nik9000@gmail.com>
Adds a
versionparameter to the ESQL_queryrequest endpoint. We'll do some work to give this a default value in the generated clients soon, but for 8.14+ this'll be a required parameter.