-
Notifications
You must be signed in to change notification settings - Fork 99
Use endpoint instead of model in the inference API #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
2c4718d
b5189cc
4afa7b4
1bd351c
a71b155
2eadedf
1aa7a9e
780abe3
48a1bec
69ff916
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,10 +17,11 @@ | |
* under the License. | ||
*/ | ||
|
||
import { ModelConfigContainer } from '@inference/_types/Services' | ||
import { InferenceEndpointContainer } from '@inference/_types/Services' | ||
|
||
export class Response { | ||
body: { | ||
models: Array<ModelConfigContainer> | ||
/** @aliases models */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we decided to break compatibility, should we keep models as an alias? For what it's worth, the current Python client does the wrong thing and would send There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree and have removed the alias. The change breaks compatibility, we can do that because the API is neither GA or heavily used therefore it should be a clean break. |
||
endpoints: Array<InferenceEndpointContainer> | ||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.