Conversation
JoshMock
approved these changes
Apr 30, 2024
Member
JoshMock
left a comment
JoshMock
left a comment
There was a problem hiding this comment.
LGTM! Does this resolve that undefined mess you found the other day?
Member
Author
|
@JoshMock Yes, that fixes the undefined namespace issue 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ts-morphprovides us with a normalized path that always uses/as the path separator (even on Windows). In this PR I replace some occurences ofsepwith just/in that context.Besides that, on Windows, multi-line strings are emitted with CRLF (
/r/n) instead of just LF (/n). I use some uglyreplacecalls to fix this. A better solution would probably be the usage of.gitattributesto make sure.tsfiles are always committed and checked out in LF style. But I'm not sure if that would cause any side-effects.TODO: Order of endpoints in the output json is not consistent between Windows and Linux. I did not dig into that for now as it does not change semantics...