Skip to content

Changed inference name to avoid duplicate #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented May 6, 2024

The java generator was complaining about types InferenceEndpointContainer and InferenceEndpoint, changed the first one's name since it's not technically a container class.

Copy link
Contributor

github-actions bot commented May 6, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete Missing test Missing test
inference.get 🔴 3/4 3/4
inference.inference Missing test Missing test
inference.put Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had a name collision with this as well.

@l-trotta l-trotta merged commit 17c8dea into main May 6, 2024
6 checks passed
@l-trotta l-trotta deleted the inference-endpoint-name-fix branch May 6, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants