Skip to content

Add ES|QL endpoint for Serverless #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

luigidellaquila
Copy link
Contributor

Fixes #2554

Adding ES|QL endpoint to Serverless specification

Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigidellaquila
Copy link
Contributor Author

Thanks @ezimuel
The CI error is completely obscure to me, but if I got it right it's unrelated to this PR, so should I just merge?

@@ -26,6 +26,7 @@ import { EsqlVersion } from '@esql/_types/EsqlVersion'
* Executes an ES|QL request
* @rest_spec_name esql.query
* @availability stack since=8.11.0 stability=experimental
* @availability serverless stability=experimental visibility=public
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's "experimental"? should that still be kept?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a "stability" value, and since ESQL is still experimental, I just used the same we have for stateful, but I don't know much more about this.

@luigidellaquila
Copy link
Contributor Author

@elasticmachine update branch

@luigidellaquila
Copy link
Contributor Author

Closing in favor of #2560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ES|QL endpoint to serverless
3 participants