Skip to content

Renaming window_size to rank_window_size for RRF in retrievers API #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024

Conversation

pmpailis
Copy link
Contributor

Relates to #2551

@pmpailis pmpailis requested a review from Anaethelion May 17, 2024 08:25
@pmpailis pmpailis changed the title Renaming window_size to rank_window_size Renaming window_size to rank_window_size for RRF in retrievers API May 17, 2024
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Anaethelion Anaethelion merged commit 9a0362e into main May 17, 2024
5 checks passed
@Anaethelion Anaethelion deleted the fix_for_retrievers_api branch May 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants