Skip to content

Add Spectral linting rules for openAPI documents #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 17, 2024

This PR adds the recommended set of Spectral linting rules and adds the linter to the makefile.

It also edits two operation summaries.

@lcawl lcawl changed the title Add operation summary for async search status Add Spectral linting rules for openAPI documents Jun 17, 2024
@lcawl lcawl requested review from a team as code owners June 17, 2024 23:01
@lcawl lcawl marked this pull request as draft June 17, 2024 23:02
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
async_search.status 🟢 3/3 3/3
ml.close_job 🟢 64/64 63/63

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@lcawl lcawl marked this pull request as ready for review June 18, 2024 14:21
@lcawl lcawl merged commit 8f60746 into main Jun 18, 2024
6 checks passed
@lcawl lcawl deleted the operation-summary-error branch June 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants