Skip to content

Fix 'Non-leaf type' errors in xpack #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix 'Non-leaf type' errors in xpack #2646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions compiler/src/steps/validate-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,23 +744,17 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
switch (fqName) {
// Base type also used as property, no polymorphic usage
case '_builtins:ErrorCause':
case 'x_pack.enrich:EnrichPolicy':
case 'x_pack.info.x_pack_usage:XPackUsage':
case 'x_pack.info.x_pack_usage:SecurityFeatureToggle':
case 'x_pack.watcher.watcher_stats:WatchRecordQueuedStats':
case 'x_pack.security.user.get_user:XPackUser':
case 'cluster.nodes_stats:MemoryStats':
case 'search.search:SearchResponse':
case 'xpack.usage:Base':
case 'xpack.usage:Counter':
case 'xpack.usage:FeatureToggle':
return

// Have a "type" attribute that identifies the variant
case 'mapping.types:PropertyBase':
case 'analysis.token_filters:TokenFilterBase':
return

// Single subclass with no additional properties, can probably be removed
case 'x_pack.watcher.input:HttpInputRequestDefinition':
return
}

if (!allowedSuperclasses.has(fqName)) {
Expand Down
30 changes: 0 additions & 30 deletions output/schema/validation-errors.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading