-
Notifications
You must be signed in to change notification settings - Fork 101
Add spec for bulk put roles #2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
9cbaabe
to
25975f4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Hey @pquentin ! I've created a new PR here and can't run the failing validation locally because I don't have the needed vault permissions. Thanks! |
Hey @jfreden, I'll reach to you privately about this. In the meantime, I can tell you that the error is that Elasticsearch YAML tests call the bulk put role API with a description but that field is missing from the RoleDescriptor class. |
This comment was marked as outdated.
This comment was marked as outdated.
Great success! Thanks @pquentin ! I was able to run this locally too. 👍 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
(Sorry for the noise, I've been testing credential changes with this pull request.) |
sorry I know this is again something not strictly related to the PR, but since the |
other than that, LGTM! |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Thanks for the review @l-trotta ! I've updated the |
* Add spec for bulk put roles (cherry picked from commit eeb4f18)
This adds a new spec for the bulk put roles API added in 8.15 in elastic/elasticsearch#109339.