Skip to content

Add specification for query users #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Add specification for query users #2684

merged 8 commits into from
Jul 10, 2024

Conversation

jfreden
Copy link
Contributor

@jfreden jfreden commented Jul 5, 2024

Add specification for Query Users added in: elastic/elasticsearch#104033 docs in: elastic/elasticsearch#104255

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.query_user 🟠 Missing type Missing type

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta self-assigned this Jul 10, 2024

/**
* Retrieves information for Users in a paginated manner. You can optionally filter the results with a query.
* @rest_spec_name security.query_api_keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be security.query_user

This comment was marked as outdated.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.query_user 🔴 3/4 4/4

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.query_user 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

1 similar comment
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.query_user 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@jfreden jfreden enabled auto-merge (squash) July 10, 2024 09:35
Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfreden jfreden merged commit ab1e338 into main Jul 10, 2024
6 checks passed
@jfreden jfreden deleted the add_spec_query_users branch July 10, 2024 10:57
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
* Add specification for query users

(cherry picked from commit ab1e338)
l-trotta pushed a commit that referenced this pull request Jul 10, 2024
* Add specification for query users

(cherry picked from commit ab1e338)

Co-authored-by: Johannes Fredén <109296772+jfreden@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants