Skip to content

[Connector API] Update endpoint stability #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Jul 5, 2024

Changes

Connector management endpoints are marked as beta: https://www.elastic.co/guide/en/elasticsearch/reference/master/connector-apis.html

This PR updates experimental -> beta stability for connector management endpoints.

@jedrazb jedrazb marked this pull request as ready for review July 5, 2024 15:36
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.delete 🔴 3/9 9/9
connector.get 🔴 59/59 1/59
connector.list 🔴 19/19 3/19
connector.post 🔴 6/7 1/7
connector.put 🔴 10/12 1/12
connector.sync_job_cancel 🟢 3/3 3/3
connector.sync_job_delete 🟢 4/4 4/4
connector.sync_job_get 🔴 22/22 21/22
connector.sync_job_list 🔴 11/12 12/12
connector.sync_job_post 🟢 50/50 50/50
connector.update_configuration 🔴 5/9 9/9
connector.update_filtering 🔴 11/12 12/12
connector.update_index_name 🟢 4/4 4/4
connector.update_name 🔴 3/4 4/4
connector.update_native 🟢 3/3 3/3
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe "Update connector API key id" defined in update_api_key_id/ConnectorUpdateAPIKeyIDRequest.ts should also be beta. The rest looks good, thanks!

@jedrazb jedrazb requested a review from pquentin July 8, 2024 09:10
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.delete 🔴 3/9 9/9
connector.get 🔴 59/59 1/59
connector.list 🔴 19/19 3/19
connector.post 🔴 6/7 1/7
connector.put 🔴 10/12 1/12
connector.sync_job_cancel 🟢 3/3 3/3
connector.sync_job_delete 🟢 4/4 4/4
connector.sync_job_get 🔴 22/22 21/22
connector.sync_job_list 🔴 11/12 12/12
connector.sync_job_post 🟢 50/50 50/50
connector.update_api_key_id 🟢 4/4 4/4
connector.update_configuration 🔴 5/9 9/9
connector.update_filtering 🔴 11/12 12/12
connector.update_index_name 🟢 4/4 4/4
connector.update_name 🔴 3/4 4/4
connector.update_native 🟢 3/3 3/3
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit the output/schema/dangling-types/dangling.csv file - we'll commit it or ignore it in a future pull request.

@jedrazb
Copy link
Member Author

jedrazb commented Jul 8, 2024

Please don't commit the output/schema/dangling-types/dangling.csv file - we'll commit it or ignore it in a future pull request.

Ahh sorry! Missed that it got included in this change, fixing

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.delete 🔴 3/9 9/9
connector.get 🔴 59/59 1/59
connector.list 🔴 19/19 3/19
connector.post 🔴 6/7 1/7
connector.put 🔴 10/12 1/12
connector.sync_job_cancel 🟢 3/3 3/3
connector.sync_job_delete 🟢 4/4 4/4
connector.sync_job_get 🔴 22/22 21/22
connector.sync_job_list 🔴 11/12 12/12
connector.sync_job_post 🟢 50/50 50/50
connector.update_api_key_id 🟢 4/4 4/4
connector.update_configuration 🔴 5/9 9/9
connector.update_filtering 🔴 11/12 12/12
connector.update_index_name 🟢 4/4 4/4
connector.update_name 🔴 3/4 4/4
connector.update_native 🟢 3/3 3/3
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 0005d71 into main Jul 8, 2024
6 checks passed
@pquentin pquentin deleted the connector-api-mark-endpoints-as-beta branch July 8, 2024 11:02
github-actions bot pushed a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants