-
Notifications
You must be signed in to change notification settings - Fork 98
Adds examples to schema.json and OpenAPI outputs #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0777b87
This featre scans All the API folders in the specfication to locate A…
siamakp-elastic 03d5e9d
Fixed lint errors
siamakp-elastic 6f028c9
Copied compiler's metadata to typescript-generated.
siamakp-elastic 72931ce
Applied suggestions in the PR request.
siamakp-elastic de56fd4
Updating the generated schema.json and the OpenAPI specs.
siamakp-elastic 6d133e8
Update typescript-generator/src/metamodel.ts
lcawl ba1e77c
Update typescript-generator/src/metamodel.ts
lcawl dc3ca31
Regenerate output
lcawl 52ecf01
Fix build error in compiler-rs
lcawl 40e3461
Add doc comments to Example's properties
swallez b594e24
Update output
swallez 8068ade
Update metamodel in ts-generator
swallez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+26.6 KB
(100%)
compiler-rs/compiler-wasm-lib/pkg/compiler_wasm_lib_bg.wasm
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will output the example as a JSON string, e.g.
"value": "{\"foo\":\"bar\"}"
instead of"value": {"foo": "bar"}
.Is this what we want? The OpenAPI spec shows that this should be a value and not a value-in-a-string.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a docs point of view, it doesn't seem to matter. For example when I run our current overlays, I get both variations and they both publish fine. For example:
as well as:
If one of these is preferable from a client point of view, that would be good to know. Otherwise from a docs point of view I'm good with whatever is easiest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the example files, I commonly saw JSON strings, but there were also instances of YAML objects. For consistency, I have converted everything to JSON strings.