From d9920e258edc912a991cd6dbd1c2ef88d9a28cf9 Mon Sep 17 00:00:00 2001
From: Quentin Pradet <quentin.pradet@elastic.co>
Date: Thu, 20 Feb 2025 13:33:59 +0400
Subject: [PATCH] Ignore errors from private APIs (#3801)

(cherry picked from commit 84571c3bff0c4a9bcfdcc05a205b3f224ede3c57)
---
 compiler/src/steps/validate-model.ts |  7 ++++
 output/schema/validation-errors.json | 60 ----------------------------
 2 files changed, 7 insertions(+), 60 deletions(-)

diff --git a/compiler/src/steps/validate-model.ts b/compiler/src/steps/validate-model.ts
index 0f3ee1fccc..b5d0045e6b 100644
--- a/compiler/src/steps/validate-model.ts
+++ b/compiler/src/steps/validate-model.ts
@@ -37,6 +37,8 @@ enum JsonEvent {
   array = 'array'
 }
 
+const privateNamespaces = ['_internal', 'profiling']
+
 /**
  * Validates the internal consistency of the model (doesn't check the json spec)
  *
@@ -208,6 +210,11 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
   function validateEndpoint (endpoint: model.Endpoint): void {
     setRootContext(endpoint.name, 'request')
 
+    // Skip validation for internal endpoints
+    if (privateNamespaces.some(ns => endpoint.name.startsWith(ns))) {
+      return
+    }
+
     if (endpoint.request == null) {
       if (endpoint.response == null) {
         modelError('Missing request & response')
diff --git a/output/schema/validation-errors.json b/output/schema/validation-errors.json
index 90af09b8e8..81f17e62d6 100644
--- a/output/schema/validation-errors.json
+++ b/output/schema/validation-errors.json
@@ -1,41 +1,5 @@
 {
   "endpointErrors": {
-    "_internal.delete_desired_balance": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "_internal.delete_desired_nodes": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "_internal.get_desired_balance": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "_internal.get_desired_nodes": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "_internal.prevalidate_node_removal": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "_internal.update_desired_nodes": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "async_search.submit": {
       "request": [
         "Request: query parameter 'min_compatible_shard_node' does not exist in the json spec",
@@ -471,30 +435,6 @@
       ],
       "response": []
     },
-    "profiling.flamegraph": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "profiling.stacktraces": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "profiling.status": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "profiling.topn_functions": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "reindex": {
       "request": [
         "Request: query parameter 'require_alias' does not exist in the json spec",