From 1f81346c0dcb8cf7875fe1c1d2b54108e9d82b61 Mon Sep 17 00:00:00 2001
From: Quentin Pradet <quentin.pradet@elastic.co>
Date: Mon, 24 Mar 2025 14:00:58 +0400
Subject: [PATCH] Stop reporting missing endpoints as errors (#4031)

We have other ways of identifying them.

(cherry picked from commit f7edcb5e57a5d17ca7a7ab30662b7c8d0b8ee19e)

# Conflicts:
#	output/schema/validation-errors.json
---
 compiler/src/steps/validate-model.ts | 13 +-----
 output/schema/validation-errors.json | 60 ----------------------------
 2 files changed, 2 insertions(+), 71 deletions(-)

diff --git a/compiler/src/steps/validate-model.ts b/compiler/src/steps/validate-model.ts
index b5d0045e6b..1dd14656a6 100644
--- a/compiler/src/steps/validate-model.ts
+++ b/compiler/src/steps/validate-model.ts
@@ -215,14 +215,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
       return
     }
 
-    if (endpoint.request == null) {
-      if (endpoint.response == null) {
-        modelError('Missing request & response')
-        return
-      } else {
-        modelError('Missing request')
-      }
-    } else {
+    if (endpoint.request !== null) {
       const reqType = getTypeDef(endpoint.request)
 
       if (reqType == null) {
@@ -266,9 +259,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
 
     setRootContext(endpoint.name, 'response')
 
-    if (endpoint.response == null) {
-      modelError('Missing response')
-    } else {
+    if (endpoint.response !== null) {
       const respType = getTypeDef(endpoint.response)
 
       if (respType == null) {
diff --git a/output/schema/validation-errors.json b/output/schema/validation-errors.json
index 89afa97b85..3aefa05c9f 100644
--- a/output/schema/validation-errors.json
+++ b/output/schema/validation-errors.json
@@ -13,12 +13,6 @@
       ],
       "response": []
     },
-    "capabilities": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "cat.aliases": {
       "request": [
         "Request: query parameter 'master_timeout' does not exist in the json spec",
@@ -182,30 +176,6 @@
       ],
       "response": []
     },
-    "connector.secret_delete": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "connector.secret_get": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "connector.secret_post": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "connector.secret_put": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "create": {
       "request": [
         "Request: query parameter 'if_primary_term' does not exist in the json spec",
@@ -232,24 +202,6 @@
       ],
       "response": []
     },
-    "fleet.delete_secret": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "fleet.get_secret": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "fleet.post_secret": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "get_source": {
       "request": [
         "Request: query parameter 'stored_fields' does not exist in the json spec"
@@ -303,12 +255,6 @@
       ],
       "response": []
     },
-    "inference.put_mistral": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "ingest.delete_geoip_database": {
       "request": [
         "Request: query parameter 'master_timeout' does not exist in the json spec",
@@ -419,12 +365,6 @@
       ],
       "response": []
     },
-    "transform.get_node_stats": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "transform.get_transform": {
       "request": [],
       "response": [