-
Notifications
You must be signed in to change notification settings - Fork 98
Add cat node -h enumerated values #4344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit af8422e)
(cherry picked from commit af8422e)
(cherry picked from commit af8422e)
|
||
export enum CatNodeColumn { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! Note however that this enum should be marked as non-exhaustive, as values like heap.*
are allowed. This is done by adding /** @non_exhaustive */
as a comment. See https://github.com/elastic/elasticsearch-specification/blob/main/docs/modeling-guide.md#enum for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #4373
This PR adds the enumerated values for the
-h
parameter in the cat nodes API.They are copied from https://www.elastic.co/guide/en/elasticsearch/reference/8.18/cat-nodes.html and implemented in a similar manner to the machine learning cat APIs, such as https://github.com/elastic/elasticsearch-specification/blob/main/specification/cat/ml_data_frame_analytics/CatDataFrameAnalyticsRequest.ts