Search endpoint fixes #4420
Search endpoint fixes #4420
Conversation
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
before it was 2316/2401 2384/2385 |
|
thanks @flobernd! let's discuss with the others, if everyone is fine with the changes we'll merge it as is. and I'll also check the other retrievers |
|
Related to #4382 |
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
|
splitting this in 2 so that the additive changes can be pushed to 8.x/9.0 and the breaking changes to 9.1 |
l-trotta
added
backport 8.19
backport 9.0
backport 8.18
and removed
skip-backport
|
|
||
| export enum ScoreNormalizer { | ||
| none, | ||
| minmax |
There was a problem hiding this comment.
can I ask to please add l2_norm here? 🥺
it was just merged this week cc @mridula-s109
EDIT: we should only add this for 9.1/8.19
There was a problem hiding this comment.
Hi @ioanatia , we have to add the l2_norm in a separate PR since this one should as well be in 8.18.
There was a problem hiding this comment.
thanks for noticing this! I'll add this in another PR since l2_norm will only be available in 8.19 and 9.1
* search endpoint fixes * revert breaking changes * added linear and pinned retriever * prettier? * Run prettier * use alias types * pretty * pretty! --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 6e14823)
* search endpoint fixes * revert breaking changes * added linear and pinned retriever * prettier? * Run prettier * use alias types * pretty * pretty! --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 6e14823)
* search endpoint fixes * revert breaking changes * added linear and pinned retriever * prettier? * Run prettier * use alias types * pretty * pretty! --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 6e14823)
* search endpoint fixes * revert breaking changes * added linear and pinned retriever * prettier? * Run prettier * use alias types * pretty * pretty! --------- (cherry picked from commit 6e14823) Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com> Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
* search endpoint fixes * revert breaking changes * added linear and pinned retriever * prettier? * Run prettier * use alias types * pretty * pretty! --------- (cherry picked from commit 6e14823) Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com> Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
* search endpoint fixes * revert breaking changes * added linear and pinned retriever * prettier? * Run prettier * use alias types * pretty * pretty! --------- (cherry picked from commit 6e14823) Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com> Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Slowly increasing validation score for
search.reasonin ErrorCause can be "null", not just missing (source: I trust the recordings for this one)geogridis actually calledgeotile(source: server code)ruleset_idsin RuleRetriever can also accept string (not going to check it's always like this with string arrays)ruleset_idsandruleset_id(which is the same just in a string format) (source: server code)WeightedTokensQuery'stokensis actually a list of WeightedToken objects, but since the field is a sting let's make it a list of Single Key Dictionaries (source: server code)HighlightField is also a Single Key Dictionary (one or many) (source: server code)The last 2 are breaking changes for static clients so I'm wondering if we should even introduce them just for the sake of validation, since it's not really broken, but it currently does not comply 100% with what the server can accept.