-
Notifications
You must be signed in to change notification settings - Fork 101
Add request details to examples #4445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6d0dfd
to
efe620e
Compare
efe620e
to
85209ed
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
2 similar comments
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huge change, but looks great to me!
If you remove the generated spec and openapi files and the example yaml files what remains is actually not a big change. This is just to use this new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM ⚡
85209ed
to
7abd582
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4445-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed5a4ebefe6e41642ae19a23d9cd43c971ac358f
# Push it to GitHub
git push --set-upstream origin backport-4445-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
* add request heading line to request examples * add request heading line to response examples * changes to the compiler to include the request heading
* add request heading line to request examples * add request heading line to response examples * changes to the compiler to include the request heading
This change adds the
method_request
field to all the example request YAML files. This field existed in these examples, but it was commented out. In addition, it adds this field to any response examples that have the information in their description field.The compiler was expanded to recognize this field as optional in all examples. The OpenAPI generator was expanded to use this field to generate the
x-codeSamples
extension, which would replace the autogenerated curl code in the blue box that bump adds in the top right of each endpoint.A follow-up change could add language versions of the example using the request converter.
The following is a list of request and/or response examples that could not be expanded to include the
method_request
field that would be needed for rendering in the docs. These should be manually reviewed and fixed to include this field: