Skip to content

Output validation comments even without changes #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 4, 2025

Otherwise, a PR that breaks validation but then restores it will keep a comment saying that validation is broken.

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.
@pquentin pquentin requested a review from a team as a code owner July 4, 2025 10:12
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit bbd5dcf into main Jul 7, 2025
8 checks passed
@pquentin pquentin deleted the no-op-changes branch July 7, 2025 12:56
Copy link
Contributor

github-actions bot commented Jul 7, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4781-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bbd5dcf5faa025686e452ce20e87a4e9b5bd6a68
# Push it to GitHub
git push --set-upstream origin backport-4781-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-4781-to-8.19.

Copy link
Contributor

github-actions bot commented Jul 7, 2025

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4781-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bbd5dcf5faa025686e452ce20e87a4e9b5bd6a68
# Push it to GitHub
git push --set-upstream origin backport-4781-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-4781-to-8.18.

Copy link
Contributor

github-actions bot commented Jul 7, 2025

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4781-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bbd5dcf5faa025686e452ce20e87a4e9b5bd6a68
# Push it to GitHub
git push --set-upstream origin backport-4781-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-4781-to-9.0.

github-actions bot pushed a commit that referenced this pull request Jul 7, 2025
* Output validation comments even without changes

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.

* Adjust output

* Try fixing branch name

* Stop trying to display the target branch

(cherry picked from commit bbd5dcf)
pquentin added a commit that referenced this pull request Jul 7, 2025
* Output validation comments even without changes

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.

* Adjust output

* Try fixing branch name

* Stop trying to display the target branch

(cherry picked from commit bbd5dcf)
pquentin added a commit that referenced this pull request Jul 7, 2025
* Output validation comments even without changes

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.

* Adjust output

* Try fixing branch name

* Stop trying to display the target branch

(cherry picked from commit bbd5dcf)
pquentin added a commit that referenced this pull request Jul 7, 2025
* Output validation comments even without changes

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.

* Adjust output

* Try fixing branch name

* Stop trying to display the target branch

(cherry picked from commit bbd5dcf)
@pquentin
Copy link
Member Author

pquentin commented Jul 7, 2025

💚 All backports created successfully

Status Branch Result
9.0
8.19
8.18

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Jul 7, 2025
* Output validation comments even without changes

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.

* Adjust output

* Try fixing branch name

* Stop trying to display the target branch

(cherry picked from commit bbd5dcf)
pquentin added a commit that referenced this pull request Jul 7, 2025
* Output validation comments even without changes

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.

* Adjust output

* Try fixing branch name

* Stop trying to display the target branch

(cherry picked from commit bbd5dcf)
pquentin added a commit that referenced this pull request Jul 7, 2025
* Output validation comments even without changes

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.

* Adjust output

* Try fixing branch name

* Stop trying to display the target branch

(cherry picked from commit bbd5dcf)
pquentin added a commit that referenced this pull request Jul 7, 2025
* Output validation comments even without changes

Otherwise, a PR that breaks validation but then restores it will keep a comment
saying that validation is broken.

* Adjust output

* Try fixing branch name

* Stop trying to display the target branch

(cherry picked from commit bbd5dcf)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants