-
Notifications
You must be signed in to change notification settings - Fork 106
[9.1] Adds new 'none' and 'recursive' chunking strategies to Inference APIs #4841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3c0c472
Adds new chunking strategies
kosabogi f856d38
Adds external link
kosabogi 4f6cbf5
Adds a sentence to point to the link
kosabogi 732d600
Resolves merge conflict
kosabogi 1dc0035
Update specification/inference/_types/Services.ts
kosabogi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add a
Description
field here to avoid the default link text?Chunking strategies
probably worksSorry if you've already planned to do this :)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this a few times, but it didn’t work, unfortunately.
I added a description to the table.csv file like this:
chunking-strategies,https://www.elastic.co/docs/explore-analyze/elastic-inference/inference-api#chunking-strategies,https://www.elastic.co/guide/en/kibana/8.18/inference-endpoints.html,Chunking strategies documentation
However, I didn’t see any results in the elasticsearch-openapi.json file, neither the previous URL nor the link description:
To understand what’s going on, I tested the exact same case that @lcawl referenced here:
#4772 (comment)
t worked perfectly for me too. The OpenAPI file was updated exactly as Lisa described in her comment.
My only guess is that the example Lisa tested wasn't for a parameter-level
externalDocs
link, but rather for a general API description, which might be treated differently by the tooling?Could that explain the difference? Any ideas? Or am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be it, I think you can only have one ext-id per API too IIRC, don't know if there's a previous one defined for this API.
There's as many exceptions as there are rules I fear 😠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also know it that way that you can have only one
ext-id
- but here, theext-id
seems to work, what doesn’t work is the unique link text 🤔@lcawl, do you happen to have any idea why this might not be working?