Skip to content

Fixed a badly formatted example #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025
Merged

Conversation

miguelgrinberg
Copy link
Contributor

This particular example was not correctly parsed by the request converter. I have fixed it to match what the description of the example says.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelgrinberg miguelgrinberg merged commit 04f612b into main Jul 14, 2025
8 checks passed
@miguelgrinberg miguelgrinberg deleted the fix-bad-put-settings-example branch July 14, 2025 10:10
github-actions bot pushed a commit that referenced this pull request Jul 14, 2025
* Fixed a badly formatted example

* Update indicesPutSettingsRequestExample3.yaml

* Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 04f612b)
github-actions bot pushed a commit that referenced this pull request Jul 14, 2025
* Fixed a badly formatted example

* Update indicesPutSettingsRequestExample3.yaml

* Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 04f612b)
github-actions bot pushed a commit that referenced this pull request Jul 14, 2025
* Fixed a badly formatted example

* Update indicesPutSettingsRequestExample3.yaml

* Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 04f612b)
github-actions bot pushed a commit that referenced this pull request Jul 14, 2025
* Fixed a badly formatted example

* Update indicesPutSettingsRequestExample3.yaml

* Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 04f612b)
miguelgrinberg added a commit that referenced this pull request Jul 14, 2025
* Fixed a badly formatted example

* Update indicesPutSettingsRequestExample3.yaml

* Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml

---------


(cherry picked from commit 04f612b)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Co-authored-by: lcawl <lcawley@elastic.co>
miguelgrinberg added a commit that referenced this pull request Jul 14, 2025
* Fixed a badly formatted example

* Update indicesPutSettingsRequestExample3.yaml

* Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml

---------


(cherry picked from commit 04f612b)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Co-authored-by: lcawl <lcawley@elastic.co>
miguelgrinberg added a commit that referenced this pull request Jul 14, 2025
* Fixed a badly formatted example

* Update indicesPutSettingsRequestExample3.yaml

* Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml

---------


(cherry picked from commit 04f612b)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Co-authored-by: lcawl <lcawley@elastic.co>
miguelgrinberg added a commit that referenced this pull request Jul 14, 2025
* Fixed a badly formatted example

* Update indicesPutSettingsRequestExample3.yaml

* Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml

---------


(cherry picked from commit 04f612b)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Co-authored-by: lcawl <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants