-
Notifications
You must be signed in to change notification settings - Fork 108
Fixed a badly formatted example #4851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
miguelgrinberg
commented
Jul 9, 2025
specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml
Show resolved
Hide resolved
miguelgrinberg
commented
Jul 10, 2025
specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml
Outdated
Show resolved
Hide resolved
…SettingsRequestExample3.yaml
lcawl
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Fixed a badly formatted example * Update indicesPutSettingsRequestExample3.yaml * Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 04f612b)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Fixed a badly formatted example * Update indicesPutSettingsRequestExample3.yaml * Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 04f612b)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Fixed a badly formatted example * Update indicesPutSettingsRequestExample3.yaml * Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 04f612b)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Fixed a badly formatted example * Update indicesPutSettingsRequestExample3.yaml * Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 04f612b)
miguelgrinberg
added a commit
that referenced
this pull request
Jul 14, 2025
* Fixed a badly formatted example * Update indicesPutSettingsRequestExample3.yaml * Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml --------- (cherry picked from commit 04f612b) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com> Co-authored-by: lcawl <lcawley@elastic.co>
miguelgrinberg
added a commit
that referenced
this pull request
Jul 14, 2025
* Fixed a badly formatted example * Update indicesPutSettingsRequestExample3.yaml * Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml --------- (cherry picked from commit 04f612b) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com> Co-authored-by: lcawl <lcawley@elastic.co>
miguelgrinberg
added a commit
that referenced
this pull request
Jul 14, 2025
* Fixed a badly formatted example * Update indicesPutSettingsRequestExample3.yaml * Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml --------- (cherry picked from commit 04f612b) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com> Co-authored-by: lcawl <lcawley@elastic.co>
miguelgrinberg
added a commit
that referenced
this pull request
Jul 14, 2025
* Fixed a badly formatted example * Update indicesPutSettingsRequestExample3.yaml * Update specification/indices/put_settings/examples/request/indicesPutSettingsRequestExample3.yaml --------- (cherry picked from commit 04f612b) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com> Co-authored-by: lcawl <lcawley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular example was not correctly parsed by the request converter. I have fixed it to match what the description of the example says.