Skip to content

Commit 5860c6e

Browse files
committed
Add fast path for single value in VALUES
1 parent 74fd66c commit 5860c6e

File tree

7 files changed

+188
-72
lines changed

7 files changed

+188
-72
lines changed

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesBytesRefAggregator.java

Lines changed: 68 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesDoubleAggregator.java

Lines changed: 7 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesFloatAggregator.java

Lines changed: 7 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesIntAggregator.java

Lines changed: 7 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesLongAggregator.java

Lines changed: 7 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/ValuesBytesRefAggregators.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public void add(int positionOffset, IntArrayBlock groupIds) {
5555
int valuesStart = ordinalIds.getFirstValueIndex(groupPosition + positionOffset);
5656
int valuesEnd = valuesStart + ordinalIds.getValueCount(groupPosition + positionOffset);
5757
for (int v = valuesStart; v < valuesEnd; v++) {
58-
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(v)));
58+
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(v)));
5959
}
6060
}
6161
}
@@ -77,7 +77,7 @@ public void add(int positionOffset, IntBigArrayBlock groupIds) {
7777
int valuesStart = ordinalIds.getFirstValueIndex(groupPosition + positionOffset);
7878
int valuesEnd = valuesStart + ordinalIds.getValueCount(groupPosition + positionOffset);
7979
for (int v = valuesStart; v < valuesEnd; v++) {
80-
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(v)));
80+
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(v)));
8181
}
8282
}
8383
}
@@ -93,7 +93,7 @@ public void add(int positionOffset, IntVector groupIds) {
9393
int valuesStart = ordinalIds.getFirstValueIndex(groupPosition + positionOffset);
9494
int valuesEnd = valuesStart + ordinalIds.getValueCount(groupPosition + positionOffset);
9595
for (int v = valuesStart; v < valuesEnd; v++) {
96-
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(v)));
96+
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(v)));
9797
}
9898
}
9999
}
@@ -135,7 +135,7 @@ public void add(int positionOffset, IntArrayBlock groupIds) {
135135
int groupEnd = groupStart + groupIds.getValueCount(groupPosition);
136136
for (int g = groupStart; g < groupEnd; g++) {
137137
int groupId = groupIds.getInt(g);
138-
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
138+
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
139139
}
140140
}
141141
}
@@ -150,7 +150,7 @@ public void add(int positionOffset, IntBigArrayBlock groupIds) {
150150
int groupEnd = groupStart + groupIds.getValueCount(groupPosition);
151151
for (int g = groupStart; g < groupEnd; g++) {
152152
int groupId = groupIds.getInt(g);
153-
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
153+
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
154154
}
155155
}
156156
}
@@ -159,7 +159,7 @@ public void add(int positionOffset, IntBigArrayBlock groupIds) {
159159
public void add(int positionOffset, IntVector groupIds) {
160160
for (int groupPosition = 0; groupPosition < groupIds.getPositionCount(); groupPosition++) {
161161
int groupId = groupIds.getInt(groupPosition);
162-
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
162+
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
163163
}
164164
}
165165

0 commit comments

Comments
 (0)