Skip to content

[otel-data] Add alias event.dataset -> data_stream.dataset #114642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

[otel-data] Add alias event.dataset -> data_stream.dataset #114642

merged 1 commit into from
Oct 14, 2024

Conversation

gregkalapos
Copy link
Contributor

event.dataset is an ECS field that is used e.g. when creating ML anomaly detection based on logs:

375005975-4bea59cf-9faf-4f13-8989-b399689bb9b6

@gregkalapos gregkalapos self-assigned this Oct 11, 2024
@gregkalapos gregkalapos requested a review from a team as a code owner October 11, 2024 16:47
@gregkalapos gregkalapos added >non-issue auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles labels Oct 11, 2024
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 11, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@felixbarny
Copy link
Member

Here's a related discussion with some of the historical context: elastic/ecs-logging#38

Given that OTel data is in different data streams, and there can't by any conflicts with an actual event.dataset field, we can finally create that alias!

@gregkalapos gregkalapos merged commit d94fbcb into elastic:main Oct 14, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 114642

@gregkalapos gregkalapos mentioned this pull request Oct 14, 2024
Merged
@gregkalapos
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

gregkalapos added a commit to gregkalapos/elasticsearch that referenced this pull request Oct 14, 2024
@gregkalapos
Add alias event.dataset -> data_stream.dataset (elastic#114642)
b319381 
(cherry picked from commit d94fbcb)
elasticsearchmachine pushed a commit that referenced this pull request Oct 14, 2024
@gregkalapos @elasticmachine
Add alias event.dataset -> data_stream.dataset (#114642) (#114702)
35792c3 
(cherry picked from commit d94fbcb)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 14, 2024
@gregkalapos @davidkyle
Add alias event.dataset -> data_stream.dataset (elastic#114642)
fea2a28
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
@gregkalapos @georgewallace
Add alias event.dataset -> data_stream.dataset (elastic#114642)
1e85125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixbarny felixbarny felixbarny approved these changes

@carsonip carsonip carsonip approved these changes

Assignees

@gregkalapos gregkalapos

Labels
auto-backport Automatically create backport pull requests when merged backport pending :Data Management/Data streams Data streams and their lifecycles external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Data Management Meta label for data/management team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gregkalapos @elasticsearchmachine @felixbarny @carsonip