Esql - Add planner information to the profile #124919
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
commented
Mar 14, 2025
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/CollectedProfiles.java
Outdated
Show resolved
Hide resolved
|
This is extremely work in progress at the moment. It's still littered with NOCOMMITs, I haven't written any tests yet, and I haven't even started on the actual profiling. I'm just pushing it up for some early feedback on how I plumbed the profile data through the query execution. |
…profile' into esql-planner-profile
Conflicts: server/src/main/java/org/elasticsearch/TransportVersions.java x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ComputeResponse.java
| @@ -346,18 +348,48 @@ public EsqlResponse responseInternal() { | |||
|
|
|||
| public static class Profile implements Writeable, ChunkedToXContentObject { | |||
There was a problem hiding this comment.
NIT: I wonder if we could make this a record?
This way we could avoid custom equals/hashCode/toString.
Merge could be updated to return a new instance instead of mutating this one
| * Stores profiling information about the query plan. This can be the top level planning on the coordinating node, or the local | ||
| * planning on the data nodes. | ||
| */ | ||
| public class PlannerProfile implements Writeable, ChunkedToXContentObject { |
There was a problem hiding this comment.
It looks like this is still work in progress, but I would suggest we try to design it to be a record from the very beginning
Conflicts: server/src/main/java/org/elasticsearch/TransportVersions.java x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/execution/PlanExecutor.java x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/EsqlPlugin.java x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/TransportEsqlQueryAction.java x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/telemetry/PlanExecutorMetricsTests.java
…profile' into esql-planner-profile
…profile' into esql-planner-profile Conflicts: x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/PlannerProfile.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to capture profile information about planning. It should cover both the initial coordinator level planning and the local replanning.