Esql - Add planner information to the profile #124919
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.xpack.esql.planner; | ||
|
|
||
| import org.elasticsearch.common.io.stream.StreamInput; | ||
| import org.elasticsearch.common.io.stream.StreamOutput; | ||
| import org.elasticsearch.common.io.stream.Writeable; | ||
| import org.elasticsearch.common.xcontent.ChunkedToXContentObject; | ||
| import org.elasticsearch.xcontent.ToXContent; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.Iterator; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Stores profiling information about the query plan. This can be the top level planning on the coordinating node, or the local | ||
| * planning on the data nodes. | ||
| */ | ||
| public class PlannerProfile implements Writeable, ChunkedToXContentObject { | ||
|
There was a problem hiding this comment. It looks like this is still work in progress, but I would suggest we try to design it to be a record from the very beginning |
||
|
|
||
| public static final class RuleProfile implements Writeable, ChunkedToXContentObject { | ||
| private final List<Long> runDurations; | ||
| private int runsWithChanges; | ||
|
|
||
| public RuleProfile() { | ||
| this.runDurations = new ArrayList<>(); | ||
| this.runsWithChanges = 0; | ||
| } | ||
|
|
||
| public RuleProfile(List<Long> durationNanos, int runsWithChanges) { | ||
| this.runDurations = durationNanos; | ||
| this.runsWithChanges = runsWithChanges; | ||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeCollection(runDurations, StreamOutput::writeLong); | ||
| out.writeInt(runsWithChanges); | ||
| } | ||
|
|
||
| public RuleProfile readFrom(StreamInput in) throws IOException { | ||
| List<Long> runDurations = in.readCollectionAsImmutableList(StreamInput::readLong); | ||
| int runsWithChanges = in.readInt(); | ||
| return new RuleProfile(runDurations, runsWithChanges); | ||
| } | ||
|
|
||
| public void addRun(long runDuration, boolean hasChanges) { | ||
| runDurations.add(runDuration); | ||
| if (hasChanges) { | ||
| runsWithChanges++; | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public Iterator<? extends ToXContent> toXContentChunked(ToXContent.Params params) { | ||
| // NOCOMMIT | ||
| return null; | ||
| } | ||
|
|
||
| // NOCOMMIT equals and hashcode, once the fields are stable | ||
| } | ||
|
|
||
| public static final PlannerProfile EMPTY = new PlannerProfile(false, ""); | ||
|
|
||
| private final boolean isLocalPlanning; | ||
| private final String nodeName; | ||
|
|
||
| private Map<String, Map<String, RuleProfile>> ruleProfiles; | ||
|
|
||
| public PlannerProfile(boolean isLocalPlanning, String nodeName) { | ||
| this.isLocalPlanning = isLocalPlanning; | ||
| this.nodeName = nodeName; | ||
| ruleProfiles = new HashMap<>(); | ||
| } | ||
|
|
||
| public static PlannerProfile readFrom(StreamInput in) throws IOException { | ||
| // NOCOMMIT - need to read back the profiles | ||
| return new PlannerProfile(in.readBoolean(), in.readString()); | ||
| } | ||
|
|
||
| public void recordRuleProfile(String batchName, String ruleName, long runDuration, boolean hasChanges) { | ||
| ruleProfiles.computeIfAbsent(batchName, k -> new HashMap<>()) | ||
| .computeIfAbsent(ruleName, k -> new RuleProfile()) | ||
| .addRun(runDuration, hasChanges); | ||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeBoolean(isLocalPlanning); | ||
| out.writeString(nodeName); | ||
| // NOCOMMIT - need to write out the profile map | ||
| } | ||
|
|
||
| @Override | ||
| public Iterator<? extends ToXContent> toXContentChunked(ToXContent.Params params) { | ||
| // NOCOMMIT | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
| // NOCOMMIT equals and hashcode, once the fields are stable | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: I wonder if we could make this a record?
This way we could avoid custom equals/hashCode/toString.
Merge could be updated to return a new instance instead of mutating this one