Add Hugging Face Rerank support #127966

Evgenii-Kazannik · 2025-05-09T11:37:59Z

Have you signed the contributor license agreement?
Have you followed the contributor guidelines?
If submitting code, have you built your formula locally prior to submission with gradle check?
If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
If submitting code, have you checked that your submission is for an OS and architecture that we support?
If you are submitting this code for a class then read our policy for that.

CA have been signed.
Used the following with success:
gradlew :x-pack:plugin:inference:check
gradlew.bat :x-pack:plugin:inference:spotlessApply

Tested via api:

PUT {{base-url}}/_inference/rerank/bge-reranker-base-mkn
{
    "service": "hugging_face",
    "service_settings": {
        "api_key": "{{hf-api-key}}",
        "url": "{{hf-bge-reranker-url}}"
    },
    "task_settings": {
        "return_documents": false
    }
}

POST {{base-url}}/_inference/rerank/bge-reranker-base-mkn
{
  "input": ["luke", "like", "leia", "chewy","r2d2", "star", "wars"],
  "query": "star wars main character",
  "top_n": 2,
  "return_documents": false
}
_____________________________________________
{
    "rerank": [
        {
            "index": 6,
            "relevance_score": 0.50955844
        },
        {
            "index": 5,
            "relevance_score": 0.084341794
        }
    ]
}

POST {{base-url}}/_inference/rerank/bge-reranker-base-mkn
{
  "input": ["luke", "like", "leia", "chewy","r2d2", "star", "wars"],
  "query": "star wars main character",
  "top_n": 3,
  "return_documents": true
}
__________________________________________________

{
    "rerank": [
        {
            "index": 6,
            "relevance_score": 0.5089636,
            "text": "wars"
        },
        {
            "index": 5,
            "relevance_score": 0.08449275,
            "text": "star"
        },
        {
            "index": 3,
            "relevance_score": 0.0045032725,
            "text": "chewy"
        }
    ]
}

Also there were the following HF task settings integrated additionally:
raw_scores, truncate, truncation_direction
For now removed from the PR saving into a distinct branch,
Just for a case if we decide to make those a part of the inference api

@jonathan-buttner @Jan-Kazlouski-elastic
Apologies for the delay. I meant to create this much sooner.
Thanks for your patience

tested on:
bge-reranker-base -> bge-reranker-base-mkn
jina-reranker-v1-turbo-en-GGUF -> jina-reranker-v1-turbo-en-gg-iuu

elasticsearch-specification PR

Jan-Kazlouski-elastic · 2025-05-09T12:24:52Z

...ice-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceBaseRestTest.java

@@ -171,6 +171,22 @@ static String mockDenseServiceModelConfig() {
            """;
    }

+    static String mockRerankServiceModelConfig() {


I'm wondering if methods you've added to this class are actually used somewhere. Methods you've taken for reference are being called. The ones you've added - are not.

Thanks for noticing. It's used now

Jan-Kazlouski-elastic · 2025-05-09T12:25:48Z

...ice-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceBaseRestTest.java

@@ -484,6 +500,10 @@ private String jsonBody(List<String> input, @Nullable String query) {
    @SuppressWarnings("unchecked")
    protected void assertNonEmptyInferenceResults(Map<String, Object> resultMap, int expectedNumberOfResults, TaskType taskType) {
        switch (taskType) {
+            case RERANK -> {


It looks like this method is not called with TaskType.RERANK param anywhere. meaning assertion isn't triggered.

Jan-Kazlouski-elastic · 2025-05-09T12:52:02Z

...main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceBaseService.java

@@ -92,14 +98,15 @@ public HuggingFaceModel parsePersistedConfigWithSecrets(
        Map<String, Object> secrets
    ) {
        Map<String, Object> serviceSettingsMap = removeFromMapOrThrowIfNull(config, ModelConfigurations.SERVICE_SETTINGS);
+        Map<String, Object> taskSettingsMap = removeFromMapOrThrowIfNull(config, ModelConfigurations.TASK_SETTINGS);


Correct me if I'm wrong. but won't that throw an exception if there are no task settings in config? If so, doesn't that affect other integrations that don't require TASK_SETTINGS to be present?

I added Rerank type check to ensure the method isn't used for other tasks

Jan-Kazlouski-elastic · 2025-05-09T12:59:03Z

...main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceBaseService.java

    }

    @Override
    public HuggingFaceModel parsePersistedConfig(String inferenceEntityId, TaskType taskType, Map<String, Object> config) {
        Map<String, Object> serviceSettingsMap = removeFromMapOrThrowIfNull(config, ModelConfigurations.SERVICE_SETTINGS);
+        Map<String, Object> taskSettingsMap = removeFromMapOrThrowIfNull(config, ModelConfigurations.TASK_SETTINGS);


Same question as above

Added type check before using the methos.Thanks

Jan-Kazlouski-elastic

Left a few comments.

Jan-Kazlouski-elastic · 2025-05-09T13:22:18Z

...sticsearch/xpack/inference/services/huggingface/request/rerank/HuggingFaceRerankRequest.java

+
+    @Override
+    public boolean[] getTruncationInfo() {
+        return null;


Can we have a comment here, explaining why null is returned?

Yeah truncation is only used in some services that support text embedding. Just say something like "Not applicable for rerank, only used in text embedding requests".

Added as suggested: Not applicable for rerank, only used in text embedding requests
Thanks all

Jan-Kazlouski-elastic · 2025-05-09T13:33:58Z

...sticsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankServiceSettings.java

+
+    @Override
+    public TransportVersion getMinimalSupportedVersion() {
+        return TransportVersions.V_8_12_0;


Please check comments related to TransportVersions left by @jonathan-buttner to this PR: #127254
They would apply here as well.

Did it, read it through, updated. I'm going to update the versions once more before the merge

Jan-Kazlouski-elastic · 2025-05-09T13:34:41Z

...elasticsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankTaskSettings.java

+
+    @Override
+    public TransportVersion getMinimalSupportedVersion() {
+        return TransportVersions.V_8_14_0;


Same thing here related to comments for TranportVersion

Thanks, applied the change

jonathan-buttner

Looking good! I left a few suggestions.

jonathan-buttner · 2025-05-09T19:32:40Z

...sticsearch/xpack/inference/services/huggingface/request/rerank/HuggingFaceRerankRequest.java

+        this.returnDocuments = returnDocuments;
+        this.topN = topN;
+        taskSettings = model.getTaskSettings();
+        this.model = model;


Since we're saving a reference to the model how about we remove the taskSettings and inferenceEntityId references and just use the model.

Thank you. Used them from the model

jonathan-buttner · 2025-05-09T19:34:11Z

.../main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceModelInput.java

+
+import java.util.Map;
+
+public class HuggingFaceModelInput {


How about we make this a record and maybe rename it to HuggingFaceModelParameters

Yep. The record fits better. Thanks. Done

jonathan-buttner · 2025-05-09T19:39:43Z

.../main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceModelInput.java

+    private final String failureMessage;
+    private final ConfigurationParseContext context;
+
+    public HuggingFaceModelInput(Builder builder) {


Should we make this private? We probably want the instantiation done through the builder.

The builder was replaced with the record as suggested so not needed anymore.
Though thank you for pointing that out

jonathan-buttner · 2025-05-09T19:42:45Z

...main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceBaseService.java

@@ -128,17 +140,13 @@ public HuggingFaceModel parsePersistedConfig(String inferenceEntityId, TaskType
            parsePersistedConfigErrorMsg(inferenceEntityId, name()),
            ConfigurationParseContext.PERSISTENT
        );
+
+        return createModel(
+            TaskType.RERANK.equals(taskType) ? modelBuilder.withTaskSettings(taskSettingsMap).build() : modelBuilder.build()


Looks like the builder accepts null task settings so how about we just pass in the task settings map, regardless of it being null or not. That way we don't need to check for rerank here.

The models accept the task settings map as is now. Thanks

jonathan-buttner · 2025-05-09T19:50:21Z

...sticsearch/xpack/inference/services/huggingface/request/rerank/HuggingFaceRerankRequest.java

+
+    @Override
+    public boolean[] getTruncationInfo() {
+        return null;


Yeah truncation is only used in some services that support text embedding. Just say something like "Not applicable for rerank, only used in text embedding requests".

jonathan-buttner · 2025-05-09T20:30:52Z

...sticsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankServiceSettings.java

+        return RERANK_TOKEN_LIMIT;
+    }
+
+    // model is not defined in the service settings.


Since we encountered situations where the model id was required for chat completion, have we done any testing to see if the serverless style endpoint requires the model id?

The thing is that HF currently does not provide serverless for Rerank models. We cannot test it now

jonathan-buttner · 2025-05-09T20:31:24Z

...sticsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankServiceSettings.java

+    @Override
+    protected XContentBuilder toXContentFragmentOfExposedFields(XContentBuilder builder, Params params) throws IOException {
+        builder.field(URL, uri.toString());
+        builder.field(MAX_INPUT_TOKENS, RERANK_TOKEN_LIMIT);


Let's remove this, since we don't use it.

Removed. Thank you

jonathan-buttner · 2025-05-09T20:36:05Z

...ticsearch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntity.java

@@ -0,0 +1,123 @@
+/*


We're trying to move away from this style of parsing and instead use an ObjectParser or ConstructingObjectParser. How about we switch this implementation to use ConstructingObjectParser? Here's an example: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/openai/response/OpenAiEmbeddingsResponseEntity.java

jonathan-buttner · 2025-05-09T20:36:50Z

...ticsearch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntity.java

+import static org.elasticsearch.common.xcontent.XContentParserUtils.throwUnknownToken;
+import static org.elasticsearch.xpack.inference.external.response.XContentUtils.moveToFirstToken;
+
+public class HuggingFaceRerankResponseEntity extends ErrorResponse {


Hmm, typically we separate the valid response from the error response. Does the HuggingFaceErrorResponseEntity suffice?

jonathan-buttner · 2025-05-09T20:39:06Z

.../org/elasticsearch/xpack/inference/services/huggingface/action/HuggingFaceActionCreator.java

+        "Failed to send Hugging Face %s request from inference entity id [%s]";
+    static final ResponseHandler RERANK_HANDLER = new HuggingFaceResponseHandler(
+        "hugging face rerank",
+        (request, response) -> HuggingFaceRerankResponseEntity.fromResponse((HuggingFaceRerankRequest) request, response)


It'd be unlikely but can we do an instanceof check for request being a HuggingFaceRerankRequest? And throw an IllegalArgumentException if it's invalid.

Good point. Thank you Jonathan. Explicit check was added

# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java

elasticsearchmachine · 2025-05-13T11:47:49Z

Pinging @elastic/ml-core (Team:ML)

Jan-Kazlouski-elastic · 2025-05-14T18:31:12Z

.../org/elasticsearch/xpack/inference/services/huggingface/action/HuggingFaceActionCreator.java

+    private static final String FAILED_TO_SEND_REQUEST_ERROR_MESSAGE =
+        "Failed to send Hugging Face %s request from inference entity id [%s]";
+    private static final String INVALID_REQUEST_TYPE_MESSAGE = "Invalid request type: expected HuggingFace %s request but got %s";
+    static final ResponseHandler RERANK_HANDLER = new HuggingFaceResponseHandler("hugging face rerank", (request, response) -> {


Why is it package private and not just private?

Jan-Kazlouski-elastic · 2025-05-15T12:13:58Z

.../org/elasticsearch/xpack/inference/services/huggingface/action/HuggingFaceActionCreator.java

-            "ELSER",
-            model.getInferenceEntityId()
-        );
+        var errorMessage = format(FAILED_TO_SEND_REQUEST_ERROR_MESSAGE, "ELSER", model.getInferenceEntityId());


I suggest adapting approach that is implemented here:
https://github.com/elastic/elasticsearch/pull/127254/files#diff-e0d9eac4ad74ebb018731efce7d8418eb03989288ed59f752ba5dbe71eac7481R97-R99
Since it is likely to be merged before your changes.

Jan-Kazlouski-elastic · 2025-05-15T12:16:09Z

...va/org/elasticsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankModel.java

+    }
+
+    @Override
+    public DefaultSecretSettings getSecretSettings() {


Do we need this method? It just calls super.method.

I'm not sure if we need it but it's a pattern we have throughout the plugin. I think it's fine to leave it.

Jan-Kazlouski-elastic

Left a few comments

# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferenceNamedWriteablesProvider.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceService.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/huggingface/action/HuggingFaceActionCreator.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/huggingface/action/HuggingFaceActionCreatorTests.java

jonathan-buttner

Looking good, I left some suggestions. Could we add some unit tests for the response parsing logic?

jonathan-buttner · 2025-05-20T15:34:31Z

...main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceBaseService.java

+            Map<String, Object> taskSettingsMap = Collections.emptyMap();
+
+            if (TaskType.RERANK.equals(taskType)) {
+                taskSettingsMap = removeFromMapOrThrowIfNull(config, ModelConfigurations.TASK_SETTINGS);


The task settings should be optional. I don't think we want to throw if the user does not specify any. In other services like cohere we default to an empty map like this:

Map<String, Object> taskSettingsMap = removeFromMapOrDefaultEmpty(config, ModelConfigurations.TASK_SETTINGS);

Let's remove the if-block and use the removeFromMapOrDefaultEmpty instead.

jonathan-buttner · 2025-05-20T15:34:56Z

...main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceBaseService.java

@@ -93,52 +103,60 @@ public HuggingFaceModel parsePersistedConfigWithSecrets(
    ) {
        Map<String, Object> serviceSettingsMap = removeFromMapOrThrowIfNull(config, ModelConfigurations.SERVICE_SETTINGS);
        Map<String, Object> secretSettingsMap = removeFromMapOrThrowIfNull(secrets, ModelSecrets.SECRET_SETTINGS);
+        Map<String, Object> taskSettingsMap = Collections.emptyMap();
+
+        if (TaskType.RERANK.equals(taskType)) {


Same comment as above, let's use Map<String, Object> taskSettingsMap = removeFromMapOrDefaultEmpty(config, ModelConfigurations.TASK_SETTINGS);

jonathan-buttner · 2025-05-20T15:35:10Z

...main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceBaseService.java

        );
    }

    @Override
    public HuggingFaceModel parsePersistedConfig(String inferenceEntityId, TaskType taskType, Map<String, Object> config) {
        Map<String, Object> serviceSettingsMap = removeFromMapOrThrowIfNull(config, ModelConfigurations.SERVICE_SETTINGS);
+        Map<String, Object> taskSettingsMap = Collections.emptyMap();
+
+        if (TaskType.RERANK.equals(taskType)) {


Same comment as above let's use:

Map<String, Object> taskSettingsMap = removeFromMapOrDefaultEmpty(config, ModelConfigurations.TASK_SETTINGS);

jonathan-buttner · 2025-05-20T15:36:30Z

...src/main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceService.java

-        ConfigurationParseContext context
-    ) {
-        return switch (taskType) {
+    protected HuggingFaceModel createModel(HuggingFaceModelParameters input) {


How about we rename input to parameters or params?

jonathan-buttner · 2025-05-20T15:42:26Z

.../org/elasticsearch/xpack/inference/services/huggingface/action/HuggingFaceActionCreator.java

    public static final String COMPLETION_ERROR_PREFIX = "Hugging Face completions";
    static final String USER_ROLE = "user";
    static final ResponseHandler COMPLETION_HANDLER = new OpenAiChatCompletionResponseHandler(
        "hugging face completion",
        OpenAiChatCompletionResponseEntity::fromResponse
    );
+    private static final ResponseHandler RERANK_HANDLER = new HuggingFaceResponseHandler("hugging face rerank", (request, response) -> {
+        var errorMessage = format(INVALID_REQUEST_TYPE_MESSAGE, "RERANK", request != null ? request.getClass().getName() : "null");


How about we use .getSimpleName() here, that version tends to be a little more readable.

Let's move this block inside the if-block so we aren't calculating the error util it's needed.

jonathan-buttner · 2025-05-20T18:22:57Z

...ticsearch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntity.java

+        return parseList(parser, (listParser, index) -> {
+            var parsedRankedDoc = HuggingFaceRerankResponseEntity.RankedDocEntry.parse(parser);
+
+            if (parsedRankedDoc.id == null) {


I believe declare*() requires that the result be non-null. So I think we can remove these if-blocks to check for non-null. Can we create a test to ensure that null is not valid?

jonathan-buttner · 2025-05-20T18:24:46Z

...ticsearch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntity.java

+
+            try {
+                return new RankedDocsResults.RankedDoc(parsedRankedDoc.id, parsedRankedDoc.score, parsedRankedDoc.text);
+            } catch (NumberFormatException e) {


I might be missing it but what logic could throw the NumberFormatException? Do we need the try/catch?

jonathan-buttner · 2025-05-20T18:41:13Z

...ticsearch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntity.java

+     * <pre>
+     *     <code>
+     *         {
+     *              "rerank": [


Does HF respond with the rerank field? Or is it just an array without the outer object?

jonathan-buttner · 2025-05-20T18:41:45Z

...ticsearch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntity.java

+        try (XContentParser jsonParser = XContentFactory.xContent(XContentType.JSON).createParser(parserConfig, response.body())) {
+            moveToFirstToken(jsonParser);
+
+            XContentParser.Token token = jsonParser.currentToken();


I think we can omit this line and the ensureExpectedToken because the parseList will do the same check.

jonathan-buttner · 2025-05-20T18:50:43Z

...xpack/inference/services/huggingface/request/rerank/HuggingFaceRerankRequestEntityTests.java

+        entity.toXContent(builder, ToXContent.EMPTY_PARAMS);
+        String xContentResult = Strings.toString(builder);
+
+        assertThat(xContentResult, equalToIgnoringWhitespaceInJsonString("""


How about we use XContentHelper.stripWhitespace() instead

# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java

Evgenii-Kazannik · 2025-05-21T13:54:05Z

additionally replaced getFirst() with get(0) in HuggingFaceActionCreatorTests. For the sake of backward compatibility

jonathan-buttner

Looking good, a few more test suggestions

jonathan-buttner · 2025-05-21T14:54:04Z

...ticsearch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntity.java

        });
    }

-    private record RankedDocEntry(@Nullable Integer id, @Nullable Float score, @Nullable String text) {
+    private record RankedDocEntry(Integer id, Float score, @Nullable String text) {


nit: let's change id to index, I think that's clearer.

jonathan-buttner · 2025-05-21T14:58:56Z

...arch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntityTests.java

+public class HuggingFaceRerankResponseEntityTests extends ESTestCase {
+    private static final String MISSED_FIELD_INDEX = "index";
+    private static final String MISSED_FIELD_SCORE = "score";
+


Let's add the following tests

responseJson with more than 1 item in the array, ensure that the score sorting works as expected

topN of null does not do any limiting

topN of 5 does not do anything for a result set of 2

topN of 2 reduces the results set of 5 to 2

jonathan-buttner · 2025-05-21T15:15:17Z

...elasticsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankTaskSettings.java

+public class HuggingFaceRerankTaskSettings implements TaskSettings {
+
+    public static final String NAME = "hugging_face_rerank_task_settings";
+    public static final String RETURN_TEXT = "return_text";


How about we use return_documents here instead? That aligns with what we allow in the root level of the request and cohere also uses that as the name of the field.

jonathan-buttner

I've been doing some testing with bge-reranker-base-mkn. It's looking good. I did notice that the top_n from the task settings doesn't seem to be applying:

PUT _inference/rerank/test
{
    "service": "hugging_face",
    "service_settings": {
        "api_key": "<api key>",
        "url": "https://vvx7nmi2feeokepr....."
    },
    "task_settings": {
        "top_n": 1,
        "return_text": true
    }
}

POST _inference/rerank/test
{
    "query": "Main characters in Star Wars",
    "input": [
        "money",
        "luke skywalker",
        "yoga",
        "darth vader",
        "han solo",
        "fruit"
    ]
}

This produces:

{
    "rerank": [
        {
            "index": 3,
            "relevance_score": 0.7399865,
            "text": "darth vader"
        },
        {
            "index": 1,
            "relevance_score": 0.099996306,
            "text": "luke skywalker"
        },
        {
            "index": 4,
            "relevance_score": 0.00040448149,
            "text": "han solo"
        },
        {
            "index": 0,
            "relevance_score": 0.00004720623,
            "text": "money"
        },
        {
            "index": 5,
            "relevance_score": 0.00003734357,
            "text": "fruit"
        },
        {
            "index": 2,
            "relevance_score": 0.00003734357,
            "text": "yoga"
        }
    ]
}

I expected there to only be a single entry in the array. If I include top_n in the request it does limit it to 1 entry.

jonathan-buttner · 2025-05-21T15:21:00Z

...icsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankTaskSettingsTests.java

+
+import static org.hamcrest.Matchers.containsString;
+
+public class HuggingFaceRerankTaskSettingsTests extends AbstractWireSerializingTestCase<HuggingFaceRerankTaskSettings> {


Let's make this extend AbstractBWCWireSerializationTestCase.

jonathan-buttner · 2025-05-21T15:21:36Z

...elasticsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankTaskSettings.java

+    private final Boolean returnDocuments;
+
+    public HuggingFaceRerankTaskSettings(StreamInput in) throws IOException {
+        this(in.readOptionalInt(), in.readOptionalBoolean());


Instead of readOptionalInt let's use readOptionalVInt and writeOptionalVInt.

jonathan-buttner · 2025-05-21T15:21:57Z

...elasticsearch/xpack/inference/services/huggingface/rerank/HuggingFaceRerankTaskSettings.java

+
+    @Override
+    public void writeTo(StreamOutput out) throws IOException {
+        out.writeOptionalInt(topNDocumentsOnly);


Let's use writeOptionalVInt.

# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java

… into Add-Hugging-Face-Rerank-support

jonathan-buttner

Thanks for the changes!

elasticsearchmachine · 2025-05-22T19:49:09Z

💔 Backport failed

Status	Branch	Result
❌	8.19	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 127966

Add Hugging Face Rerank support

4d9ec59

elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 9, 2025

Jan-Kazlouski-elastic reviewed May 9, 2025

View reviewed changes

jonathan-buttner requested changes May 9, 2025

View reviewed changes

Evgenii-Kazannik added 2 commits May 13, 2025 13:31

Address comments

b58aab4

Merge branch 'main' into Add-Hugging-Face-Rerank-support

c567137

# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java

PeteGillinElastic added :ml Machine learning and removed needs:triage Requires assignment of a team area label labels May 13, 2025

elasticsearchmachine added the Team:ML Meta label for the ML team label May 13, 2025

Evgenii-Kazannik added 5 commits May 13, 2025 14:36

Add transport version

a4ebb87

Merge branch 'main' into Add-Hugging-Face-Rerank-support

5d316c1

Add transport version

f74e9e5

Merge branch 'main' into Add-Hugging-Face-Rerank-support

2ea07f0

Add to inference service and crud IT rerank tests

0054891

Jan-Kazlouski-elastic reviewed May 14, 2025

View reviewed changes

Jan-Kazlouski-elastic reviewed May 15, 2025

View reviewed changes

Evgenii-Kazannik added 2 commits May 16, 2025 09:12

Merge branch 'main' into Add-Hugging-Face-Rerank-support

82fd86d

Refactor slightly / error message

733818c

Evgenii-Kazannik mentioned this pull request May 19, 2025

Update specification for Hugging Face rerank elastic/elasticsearch-specification#4381

Open

jonathan-buttner added auto-backport Automatically create backport pull requests when merged v8.19.0 labels May 19, 2025

jonathan-buttner self-assigned this May 19, 2025

jonathan-buttner added the >enhancement label May 19, 2025

Evgenii-Kazannik added 3 commits May 19, 2025 20:01

correct 'testGetConfiguration' test case

f97f818

Merge branch 'main' into Add-Hugging-Face-Rerank-support

88d6929

jonathan-buttner requested changes May 20, 2025

View reviewed changes

Evgenii-Kazannik added 3 commits May 21, 2025 14:42

apply suggestions

a52a1d8

Merge branch 'main' into Add-Hugging-Face-Rerank-support

2eae767

# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java

fix tests

c8c74d6

jonathan-buttner requested changes May 21, 2025

View reviewed changes

jonathan-buttner reviewed May 21, 2025

View reviewed changes

jonathan-buttner requested changes May 21, 2025

View reviewed changes

Evgenii-Kazannik and others added 7 commits May 22, 2025 04:09

apply suggestions

ae1a1d2

Merge branch 'main' into Add-Hugging-Face-Rerank-support

1764a4d

# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java

[CI] Auto commit changes from spotless

7f30c6a

add changelog information

4ee7f1f

Merge branch 'main' into Add-Hugging-Face-Rerank-support

887389f

Merge remote-tracking branch 'origin/Add-Hugging-Face-Rerank-support'…

68755a6

… into Add-Hugging-Face-Rerank-support

Merge branch 'main' into Add-Hugging-Face-Rerank-support

43398ca

jonathan-buttner approved these changes May 22, 2025

View reviewed changes

jonathan-buttner merged commit c7cf850 into elastic:main May 22, 2025
20 checks passed

elasticsearchmachine added the backport pending label May 22, 2025


		import static org.hamcrest.Matchers.containsString;

		public class HuggingFaceRerankTaskSettingsTests extends AbstractWireSerializingTestCase<HuggingFaceRerankTaskSettings> {

Add Hugging Face Rerank support #127966

Add Hugging Face Rerank support #127966

Uh oh!

Conversation

Evgenii-Kazannik commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Evgenii-Kazannik May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jan-Kazlouski-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonathan-buttner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Evgenii-Kazannik May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticsearchmachine commented May 13, 2025

Evgenii-Kazannik commented May 9, 2025 •

edited

Loading

Evgenii-Kazannik May 13, 2025 •

edited

Loading

Evgenii-Kazannik May 13, 2025 •

edited

Loading