Add Hugging Face Rerank support #127966
+1,485
−85
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.xpack.inference.services.huggingface; | ||
|
|
||
| import org.elasticsearch.core.Nullable; | ||
| import org.elasticsearch.inference.ChunkingSettings; | ||
| import org.elasticsearch.inference.TaskType; | ||
| import org.elasticsearch.xpack.inference.services.ConfigurationParseContext; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| public class HuggingFaceModelInput { | ||
|
There was a problem hiding this comment. How about we make this a record and maybe rename it to There was a problem hiding this comment. Yep. The record fits better. Thanks. Done |
||
| private final String inferenceEntityId; | ||
| private final TaskType taskType; | ||
| private final Map<String, Object> serviceSettings; | ||
| @Nullable | ||
| private final Map<String, Object> taskSettings; | ||
| private final ChunkingSettings chunkingSettings; | ||
| @Nullable | ||
| private final Map<String, Object> secretSettings; | ||
| private final String failureMessage; | ||
| private final ConfigurationParseContext context; | ||
|
|
||
| public HuggingFaceModelInput(Builder builder) { | ||
|
There was a problem hiding this comment. Should we make this private? We probably want the instantiation done through the builder. There was a problem hiding this comment. The builder was replaced with the record as suggested so not needed anymore. |
||
| this.inferenceEntityId = builder.inferenceEntityId; | ||
| this.taskType = builder.taskType; | ||
| this.serviceSettings = builder.serviceSettings; | ||
| this.taskSettings = builder.taskSettings; | ||
| this.chunkingSettings = builder.chunkingSettings; | ||
| this.secretSettings = builder.secretSettings; | ||
| this.failureMessage = builder.failureMessage; | ||
| this.context = builder.context; | ||
| } | ||
|
|
||
| public String getInferenceEntityId() { | ||
| return inferenceEntityId; | ||
| } | ||
|
|
||
| public TaskType getTaskType() { | ||
| return taskType; | ||
| } | ||
|
|
||
| public Map<String, Object> getServiceSettings() { | ||
| return serviceSettings; | ||
| } | ||
|
|
||
| @Nullable | ||
| public Map<String, Object> getTaskSettings() { | ||
| return taskSettings; | ||
| } | ||
|
|
||
| public ChunkingSettings getChunkingSettings() { | ||
| return chunkingSettings; | ||
| } | ||
|
|
||
| @Nullable | ||
| public Map<String, Object> getSecretSettings() { | ||
| return secretSettings; | ||
| } | ||
|
|
||
| public String getFailureMessage() { | ||
| return failureMessage; | ||
| } | ||
|
|
||
| public ConfigurationParseContext getContext() { | ||
| return context; | ||
| } | ||
|
|
||
| public static class Builder { | ||
| private String inferenceEntityId; | ||
| private TaskType taskType; | ||
| private Map<String, Object> serviceSettings; | ||
| @Nullable | ||
| private Map<String, Object> taskSettings; | ||
| private ChunkingSettings chunkingSettings; | ||
| @Nullable | ||
| Map<String, Object> secretSettings; | ||
| private String failureMessage; | ||
| private ConfigurationParseContext context; | ||
|
|
||
| public Builder( | ||
| String inferenceEntityId, | ||
| TaskType taskType, | ||
| Map<String, Object> serviceSettings, | ||
| ChunkingSettings chunkingSettings, | ||
| @Nullable Map<String, Object> secretSettings, | ||
| String failureMessage, | ||
| ConfigurationParseContext context | ||
| ) { | ||
| this.inferenceEntityId = inferenceEntityId; | ||
| this.taskType = taskType; | ||
| this.serviceSettings = serviceSettings; | ||
| this.chunkingSettings = chunkingSettings; | ||
| this.secretSettings = secretSettings; | ||
| this.failureMessage = failureMessage; | ||
| this.context = context; | ||
| } | ||
|
|
||
| public Builder withTaskSettings(Map<String, Object> taskSettings) { | ||
| this.taskSettings = taskSettings; | ||
| return this; | ||
| } | ||
|
|
||
| public HuggingFaceModelInput build() { | ||
| return new HuggingFaceModelInput(this); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if methods you've added to this class are actually used somewhere. Methods you've taken for reference are being called. The ones you've added - are not.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing. It's used now