-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Add XmlProcessor initial implementation #130337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marc-gr
wants to merge
15
commits into
elastic:main
Choose a base branch
from
marc-gr:feat/xml-processor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,591
−1
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
67dd264
Add XmlProcessor initial implementation
marc-gr 16e129e
[CI] Auto commit changes from spotless
elasticsearchmachine 12f4560
Make factory static
marc-gr 0a72059
[CI] Auto commit changes from spotless
elasticsearchmachine 3a5689e
Update docs/changelog/130337.yaml
marc-gr 23f80b0
Merge remote-tracking branch 'upstream/main' into feat/xml-processor
marc-gr 0ec3e67
feat: rewrite XML processor for Logstash feature parity
marc-gr 002802d
[CI] Auto commit changes from spotless
elasticsearchmachine 55ebcf9
fix: implement Copilot PR review suggestions
marc-gr 62e8875
Merge branch 'feat/xml-processor' of github.com:marc-gr/elasticsearch…
marc-gr 6e531b2
[CI] Auto commit changes from spotless
elasticsearchmachine b21b172
Merge remote-tracking branch 'upstream/main' into feat/xml-processor
marc-gr c0bb859
Merge branch 'feat/xml-processor' of github.com:marc-gr/elasticsearch…
marc-gr d8553ef
Merge branch 'main' into feat/xml-processor
marc-gr e7f8c6b
Merge branch 'main' into feat/xml-processor
marc-gr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
pr: 130337 | ||
summary: Add `XmlProcessor` initial implementation | ||
area: Ingest Node | ||
type: enhancement | ||
issues: | ||
- 97364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,6 +159,9 @@ Refer to [Enrich your data](docs-content://manage-data/ingest/transform-enrich/d | |
[`split` processor](/reference/enrich-processor/split-processor.md) | ||
: Splits a field into an array of values. | ||
|
||
[`xml` processor](/reference/enrich-processor/xml-processor.md) | ||
: Parses XML documents and converts them to JSON objects. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: It looks like the contents of this section are in alphabetical order. So can you move this after the |
||
[`trim` processor](/reference/enrich-processor/trim-processor.md) | ||
: Trims whitespace from field. | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This is going into the release notes, so we should phrase it in a more user-facing way. Something like "Add
xml
ingest processor for parsing XML", maybe.