Skip to content

Mute tests in SSLErrorMessageFileTests that rely on Security Manager #130474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 9, 2025

Conversation

gmjehovich
Copy link
Contributor

This PR mutes tests in SSLErrorMessageFileTests that are failing due to their reliance on Security Manager, which has been replaced by Entitlements in ES.

There is no way to use Entitlements in unit testing. Therefore, we need to mute these tests until Entitlements is enabled for unit tests. The original test failure tickets have been reassigned to the Core Infra team, who will own unmuting the test once Entitlements is enabled in unit testing.

References #127192 #127193 #127190

@gmjehovich gmjehovich requested a review from n1v0lg July 2, 2025 15:25
@gmjehovich gmjehovich self-assigned this Jul 2, 2025
@gmjehovich gmjehovich added >non-issue :Security/TLS SSL/TLS, Certificates Team:Core/Infra Meta label for core/infra team Team:Security Meta label for security team auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure v9.0.2 v8.17.8 v8.18.3 labels Jul 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@gmjehovich gmjehovich changed the title Mute tests in SSLErrorMessageFileTests that rely on Entitlements Mute tests in SSLErrorMessageFileTests that rely on Security Manager Jul 2, 2025
Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmjehovich gmjehovich merged commit 950e129 into elastic:main Jul 9, 2025
39 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.19 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts
8.17 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 130474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Entitlements Entitlements infrastructure >non-issue :Security/TLS SSL/TLS, Certificates Team:Core/Infra Meta label for core/infra team Team:Security Meta label for security team v8.17.8 v8.18.3 v8.19.0 v9.0.2 v9.1.0 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants