Add RerankRequestChunker #130485
Draft
Add RerankRequestChunker #130485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
:ml
|
@elasticmachine merge upstream |
dan-rubinstein
commented
Jul 18, 2025
| @@ -74,6 +74,7 @@ protected void doInference( | |||
| InferenceService service, | |||
| ActionListener<InferenceServiceResults> listener | |||
| ) { | |||
|
|
|||
There was a problem hiding this comment.
This can be removed.
dan-rubinstein
commented
Jul 18, 2025
| @@ -156,6 +156,7 @@ protected RankFeatureDoc[] preprocess(RankFeatureDoc[] originalDocs, boolean rer | |||
| } | |||
|
|
|||
| protected InferenceAction.Request generateRequest(List<String> docFeatures) { | |||
| // TODO: Try running the RerankRequestChunker here. | |||
There was a problem hiding this comment.
This can be removed as we're calling this in the service now.
davidkyle
added
the
cloud-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #121567
This is a POC for testing the proposed process. The issue above has some decisions that still need to be made in order to properly complete the implementation.
Questions remaining: