Adding a test for data stream effective mappings #130491
Merged
+108
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Data streams
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
There was a problem hiding this comment.
Pull Request Overview
Adds a new YAML REST test case that verifies how effective_mappings is computed for a data stream backed only by component templates and after applying overrides and rollover.
- Introduces a test block "Test mappings component templates only"
- Covers
get_data_stream,put_data_stream_mappings,rollover, andget_data_stream_mappingsscenarios - Asserts initial absence of mappings, correct merge of overrides, and null
effective_mappingson certain endpoints
Comments suppressed due to low confidence (1)
modules/data-streams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/250_data_stream_mappings.yml:201
- This match assertion is missing a colon before
null. It should be{ data_streams.0.mappings: null }to be valid YAML and align with other assertions.
- match: { data_streams.0.mappings null }
lukewhiting
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new test that show what exactly comes back as effective_mappings from the data stream mappings APIs. Right now, it is just the template mapping merged with the mapping overrides. Component template mappings are not considered (they are used during rollover though).