-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[DOCS][8.x]:Update depreciation notice for index mapping updates privileges #130916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
the {ref}/indices-put-mapping.html[updating mapping API] or by relying on | ||
{ref}/dynamic-mapping.html[dynamic field mapping]. In a future major release, | ||
this privilege will not grant any mapping update permissions. | ||
deprecated:[8.0] Starting from 8.0, this privilege no longer grants the permission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we call this a change
rather than a deprecation
? Or maybe a notice
? Or something like a partial deprecation
? Do we have a clear nomenclature for what such a thing should be called?
My point is that the "deprecated" term tends to push people away from the feature, rather than bringing attention to what exactly changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I used deprecated:[8.0]
just for the visual effect, since the syntax doesn’t support alternatives like change
. I used an important
block instead in the 9.x PR, and added the same here. Let me know what you think!
I went with IMPORTANT
admonition because it felt like the clearest fit, but if you think NOTE
would be more appropriate, happy to switch.
Here’s the list of supported admonitions and when to use them: https://elastic.github.io/docs-builder/syntax/admonitions/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
…ileges (#130916) * Update index mapping update privileges * Remove `depricated` tag
…ileges (#130916) * Update index mapping update privileges * Remove `depricated` tag
This PR updates the depreciation notice for 4 write-related operations on indices: (8.x asciidoc version)
create
create_doc
index
write
Based on: elastic/docs-content#1668
9.x Version: #130894