Skip to content

Remove 'index' from snapshot clear_cache query params #131067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pquentin
Copy link
Member

Since it's already part of the path parts, it's not useful to duplicate it in query parameters. (All path parts can be query parameters, but we don't usually duplicate them.)

However, if it's considered a bad idea, I can adjust the Elasticsearch specification instead.

It's already part of the path parts, it's not useful to duplicate it in query
parameters.
@pquentin pquentin added >non-issue auto-backport Automatically create backport pull requests when merged :Distributed Indexing/Searchable Snapshots Searchable snapshots / frozen indices. v9.2.0 v9.1.1 v8.19.1 v9.0.5 v8.18.5 labels Jul 11, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label Jul 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

Copy link
Contributor

@lkts lkts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@pquentin pquentin merged commit 8fb9fb5 into elastic:main Jul 17, 2025
33 checks passed
pquentin added a commit to pquentin/elasticsearch that referenced this pull request Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query
parameters.
pquentin added a commit to pquentin/elasticsearch that referenced this pull request Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query
parameters.
pquentin added a commit to pquentin/elasticsearch that referenced this pull request Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query
parameters.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1
8.19
9.0
8.18

pquentin added a commit to pquentin/elasticsearch that referenced this pull request Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query
parameters.
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 17, 2025
It's already part of the path parts, it's not useful to duplicate it in query
parameters.
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
)

It's already part of the path parts, it's not useful to duplicate it in query
parameters.
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
)

It's already part of the path parts, it's not useful to duplicate it in query
parameters.
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
)

It's already part of the path parts, it's not useful to duplicate it in query
parameters.
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
)

It's already part of the path parts, it's not useful to duplicate it in query
parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Distributed Indexing/Searchable Snapshots Searchable snapshots / frozen indices. >non-issue Team:Distributed Indexing Meta label for Distributed Indexing team v8.18.5 v8.19.1 v9.0.5 v9.1.1 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants