Skip to content

Build Tasks to Find and Verify TransportVersion Definitions #131782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Aug 1, 2025

Conversation

JVerwolf
Copy link
Contributor

@JVerwolf JVerwolf commented Jul 23, 2025

This PR introduces a set of build tasks to find and verify TransportVersion definitions using the new model.

This includes:

  1. A task to locate all transport version declarations of the form TransportVersion.fromName("some_name");, and record all the String literal arguments in a build file.
  2. A task to verify that all TransportVersion declarations have a corresponding data file
  3. A task to verify that all TransportVersion data files have a corresponding declaration
  4. A task to produce a manifest file that contains the filenames of all data files, for later use in a getResources call.

A subsequent PR will introduce a task to generate the data files.

Jiras:
ES-12335
ES-12336
ES-12398
ES-12338

@JVerwolf JVerwolf changed the title [WIP] Add task to scan for TV instantiations Build Tasks to Find and Verify TransportVersion Definitions Jul 25, 2025
@JVerwolf JVerwolf requested a review from a team July 25, 2025 20:41
@JVerwolf JVerwolf added auto-backport Automatically create backport pull requests when merged v8.18.0 v9.1.1 labels Jul 25, 2025
@JVerwolf JVerwolf requested a review from mark-vieira July 25, 2025 20:43
@JVerwolf JVerwolf marked this pull request as ready for review July 25, 2025 20:45
@JVerwolf JVerwolf requested a review from a team as a code owner July 25, 2025 20:45
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jul 25, 2025
@rjernst rjernst added :Core/Infra/Core Core issues without another label >refactoring :Delivery/Build Build or test infrastructure and removed needs:triage Requires assignment of a team area label >enhancement labels Jul 29, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team labels Jul 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@jdconrad
Copy link
Contributor

@elasticmachine run elasticsearch-ci/bwc-snapshots-part3

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Jul 31, 2025
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rjernst rjernst merged commit 4856d35 into elastic:main Aug 1, 2025
33 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts
8.19 Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Core Core issues without another label :Delivery/Build Build or test infrastructure >refactoring serverless-linked Added by automation, don't add manually Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team v8.18.0 v8.19.1 v9.0.5 v9.1.1 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants