Skip to content

ESQL: Fix StdDev test for NaN results #132195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

ivancea
Copy link
Contributor

@ivancea ivancea commented Jul 30, 2025

Failed in CI, reproducible with the test and seed:

gradlew":x-pack:plugin:esql:test" --tests "org.elasticsearch.xpack.esql.expression.function.aggregate.StdDevTests.testAggregate {TestCase=<double> #4}" -Dtests.seed=3B09675353FB805D

@ivancea ivancea requested a review from limotova July 30, 2025 15:47
@ivancea ivancea added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.2.0 v9.1.1 v8.19.1 v9.0.5 v8.18.5 labels Jul 30, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@limotova limotova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ivancea ivancea enabled auto-merge (squash) July 31, 2025 07:36
@ivancea ivancea merged commit 3dc75ff into elastic:main Jul 31, 2025
33 checks passed
@ivancea ivancea deleted the esql-fix-test-stddev branch July 31, 2025 08:35
ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jul 31, 2025
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1
8.19
9.0
8.18

ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jul 31, 2025
ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jul 31, 2025
ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jul 31, 2025
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.5 v8.19.1 v9.0.5 v9.1.1 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants