test: fix SparseVectorFieldMapperTests edge case #132937
Open
+49
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mromaios
added
>test
elasticsearchmachine
added
Team:SearchOrg
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
mromaios
removed
>test-failure
Mikep86
reviewed
Aug 14, 2025
server/src/test/java/org/elasticsearch/index/mapper/vectors/SparseVectorFieldMapperTests.java
Outdated
Show resolved
Hide resolved
Comment on lines
846
to
848
| IndexVersion indexVersion = ESTestCase.randomFrom( | ||
| IndexVersionUtils.allReleasedVersions().subSet(SPARSE_VECTOR_PRUNING_INDEX_OPTIONS_SUPPORT_BACKPORT_8_X, IndexVersion.current()) | ||
| ); |
There was a problem hiding this comment.
Can you add a TODO here about why we are using randomFrom and that we should go back to IndexVersionUtils.randomVersionBetween once issues have been resolved with that?
The other thing we would want to improve here is making it equally likely we get one of these cases:
- 8.x index version prior to index options support
- 8.x index version with index options support
- 9.x index version prior to index options support
- 9.x index version with index options support
As written, the likelihood that we get an index version prior to index options support will shrink as the number of versions between SPARSE_VECTOR_PRUNING_INDEX_OPTIONS_SUPPORT_BACKPORT_8_X and IndexVersion.current() increases.
There was a problem hiding this comment.
Sure! Updated in 1b60a47
…maios/elasticsearch into 132810_fix_sparse_vector_field_tests
This was referenced Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132810
Follow up from: #132264
This PR: