Skip to content

catalog-info: run 7.17 DRA daily #17578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

v1v
Copy link
Member

@v1v v1v commented Apr 22, 2025

Release notes

[rn:skip]

What does this PR do?

Run DRA for the 7.17 branch explicitly.

Why is it important/What is the impact to the user?

7.17 might not be listed as a supported branch in https://storage.googleapis.com/artifacts-api/snapshots/branches.json. This should help with running for the DRA.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

$ INCLUDE_NEW_BRANCHES=7.17,7.x \
  PIPELINES_TO_TRIGGER=foo \
  .buildkite/scripts/common/trigger-pipeline-generate-steps.sh

produces:

--- Printing generated steps
steps:
  - trigger: foo
    label: ":testexecute: Triggering foo / 7.17"
    build:
      branch: "7.17"
      message: ":testexecute: Scheduled build for 7.17"
  - trigger: foo
    label: ":testexecute: Triggering foo / 7.x"
    build:
      branch: "7.x"
      message: ":testexecute: Scheduled build for 7.x"
  - trigger: foo
    label: ":testexecute: Triggering foo / 8.17"
    build:
      branch: "8.17"
      message: ":testexecute: Scheduled build for 8.17"
  - trigger: foo
    label: ":testexecute: Triggering foo / 8.18"
    build:
      branch: "8.18"
      message: ":testexecute: Scheduled build for 8.18"
  - trigger: foo
    label: ":testexecute: Triggering foo / 8.19"
    build:
      branch: "8.19"
      message: ":testexecute: Scheduled build for 8.19"
  - trigger: foo
    label: ":testexecute: Triggering foo / 8.x"
    build:
      branch: "8.x"
      message: ":testexecute: Scheduled build for 8.x"
  - trigger: foo
    label: ":testexecute: Triggering foo / 9.0"
    build:
      branch: "9.0"
      message: ":testexecute: Scheduled build for 9.0"
  - trigger: foo
    label: ":testexecute: Triggering foo / main"
    build:
      branch: "main"
      message: ":testexecute: Scheduled build for main"
--- Uploading steps to buildkite

Related issues

Use cases

Screenshots

Logs

Copy link

mergify bot commented Apr 22, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@v1v v1v self-assigned this Apr 23, 2025
@v1v v1v added the backport-skip Skip automated backport with mergify label Apr 23, 2025
@v1v v1v marked this pull request as ready for review April 23, 2025 10:38
@@ -555,25 +555,29 @@ spec:
message: Daily trigger of Snapshot DRA Pipeline per branch
env:
PIPELINES_TO_TRIGGER: 'logstash-dra-snapshot-pipeline'
INCLUDE_NEW_BRANCHES: '7.17'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good plan to keep DRA but isn't early to remove 7.17 from https://storage.googleapis.com/artifacts-api/snapshots/branches.json (AFAIK 6-months after 9.0 release from support perspective)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage.googleapis.com/artifacts-api/snapshots/branches.json uses https://artifacts-api.elastic.co/v1/versions and that API relies on artifacts being generated at least once every 30 days or so. We are waiting for the official Release API that the platform release productivity team are working on.

To play safe, I thought it would be interesting to support INCLUDE_NEW_BRANCHES to explicitly say what other branches need to be supported. But we can skip this for now and revisit it if needed in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for the explanation and makes sense to me.

@v1v v1v marked this pull request as draft April 24, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants