-
Notifications
You must be signed in to change notification settings - Fork 3.5k
catalog-info: run 7.17 DRA daily #17578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @v1v? 🙏
|
|
💚 Build Succeeded
History
|
@@ -555,25 +555,29 @@ spec: | |||
message: Daily trigger of Snapshot DRA Pipeline per branch | |||
env: | |||
PIPELINES_TO_TRIGGER: 'logstash-dra-snapshot-pipeline' | |||
INCLUDE_NEW_BRANCHES: '7.17' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good plan to keep DRA but isn't early to remove 7.17 from https://storage.googleapis.com/artifacts-api/snapshots/branches.json (AFAIK 6-months after 9.0 release from support perspective)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storage.googleapis.com/artifacts-api/snapshots/branches.json uses https://artifacts-api.elastic.co/v1/versions and that API relies on artifacts being generated at least once every 30 days or so. We are waiting for the official Release API that the platform release productivity team are working on.
To play safe, I thought it would be interesting to support INCLUDE_NEW_BRANCHES
to explicitly say what other branches need to be supported. But we can skip this for now and revisit it if needed in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you for the explanation and makes sense to me.
Release notes
[rn:skip]
What does this PR do?
Run DRA for the
7.17
branch explicitly.Why is it important/What is the impact to the user?
7.17
might not be listed as a supported branch in https://storage.googleapis.com/artifacts-api/snapshots/branches.json. This should help with running for the DRA.Checklist
Author's Checklist
How to test this PR locally
produces:
Related issues
Use cases
Screenshots
Logs