Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 22, 2025

Release notes

[rn:skip]

What does this PR do?

This PR addresses the following linting errors reported


[1] redocly.yaml:29:3 at #/rules/path-excludes-patterns

Property `path-excludes-patterns` is not expected here.

27 | no-ambiguous-paths: warn
28 | no-identical-paths: error
29 | path-excludes-patterns:
30 |   severity: error
31 |   patterns:

Warning was generated by the configuration struct rule.

[2] redocly.yaml:37:3 at #/rules/spec

Property `spec` is not expected here.

35 |  operation-2xx-response: off
36 | # Schema
37 |  spec: off
38 |  spec-strict-refs: off
39 | # Tags

Warning was generated by the configuration struct rule.

...

[2] logstash-api.yaml:2267:15 at #/components/schemas/PipelineReloadStats/properties/reloads/properties/last_error/nullable

Property `nullable` is not expected here.

2265 | last_error:
2266 |   type: string
2267 |   nullable: true
2268 | successes:
2269 |   type: integer

Error was generated by the struct rule.

Why is it important/What is the impact to the user?

The redocly linter's behaviour changed per https://redocly.com/docs/cli/guides/migrate-to-v2 thus the configuration needed to be updated.

nullable: true is the format for OpenAPI 3.0 and that also changed in 3.1 so updates were required in that formatting too.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

N/A

How to test this PR locally

redocly lint logstash-api.yaml --config redocly.yaml

Related issues

N/A

Use cases

N/A

Screenshots

N/A

Logs

N/A

@lcawl lcawl added docs backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Aug 22, 2025
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review August 22, 2025 19:57
@lcawl lcawl requested review from karenzone and kaisecheng August 22, 2025 19:59
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@lcawl lcawl merged commit 34a7c67 into elastic:main Aug 22, 2025
11 of 12 checks passed
@lcawl lcawl deleted the nullable-oas branch August 22, 2025 20:29
Copy link
Contributor

@Mergifyio backport 9.0 9.1

Copy link
Contributor

mergify bot commented Aug 22, 2025

backport 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 22, 2025
(cherry picked from commit 34a7c67)

# Conflicts:
#	docs/static/spec/openapi/logstash-api.yaml
mergify bot pushed a commit that referenced this pull request Aug 22, 2025
lcawl pushed a commit that referenced this pull request Sep 22, 2025
lcawl added a commit that referenced this pull request Sep 22, 2025
…18021)

(cherry picked from commit 34a7c67)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants