Run unit tests with full set of gems #18330
Closed
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously unit tests were run with a subset of gems. This masked issues where conflicts (specifically with loading jar-dependencies) with gem load/activation were causing issues. This updates the tests to install the full gem set for unit tests. The added test time is minimal (less than a minute) and should give us a more consistent gem environment for testing.
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
donoghuc
added
the
backport-active-all
Collaborator
💚 Build Succeeded
|
donoghuc
added a commit
to donoghuc/logstash
that referenced
this pull request
Nov 4, 2025
This commit adds the installDefaultGems task to the unit test tasks. This ensures that the gem env tested at the unit level matches the deduplicated one at the integration/acceptance level. Takes over elastic#18330
Member
Author
|
Closing as this is now coming in to play with #18340. We want to ensure at the unit level that the deduplicated gem set is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Previously unit tests were run with a subset of gems. This masked issues where conflicts (specifically with loading jar-dependencies) with gem load/activation were causing issues. This updates the tests to install the full gem set for unit tests. The added test time is minimal (less than a minute) and should give us a more consistent gem environment for testing.
See #17873 for more details.