refactor: use std::map::try_emplace() over std::map::insert()
#46761
+15
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
semver/patch
There was a problem hiding this comment.
Pull Request Overview
This PR refactors map insertions to use std::map::try_emplace() in favor of std::map::insert() to leverage more efficient move semantics and clearer intent when handling duplicate keys.
- Replaced std::map::insert() with std::map::try_emplace() across several modules.
- Updated USB, USB delegate, serial delegate, proxying URL loader factory, HID delegate, file system access, and autofill driver factory code.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shell/browser/usb/usb_chooser_context.cc | Replaced insert() with try_emplace() to simplify device insertion |
| shell/browser/usb/electron_usb_delegate.cc | Updated controller map insertion to use try_emplace() |
| shell/browser/serial/electron_serial_delegate.cc | Updated controller map insertion with try_emplace() |
| shell/browser/net/proxying_url_loader_factory.cc | Converted map insertion code to try_emplace() for improved move semantics |
| shell/browser/hid/electron_hid_delegate.cc | Updated controller map insertion using try_emplace() |
| shell/browser/file_system_access/file_system_access_permission_context.cc | Replaced insert() with try_emplace() in directory mapping |
| shell/browser/electron_autofill_driver_factory.cc | Used try_emplace() for driver mapping improvement |
Files not reviewed (1)
- shell/browser/notifications/mac/cocoa_notification.mm: Language not supported
ckerr
force-pushed
the
refactor/prefer-std-map-try-emplace-over-insert
branch
from
76a7d88 to
1580e42
Compare
codebytere
approved these changes
Apr 25, 2025
ckerr
changed the title
std::map::try_emplace() over std::map::insert()std::map::try_emplace() over std::map::insert()
ckerr
force-pushed
the
refactor/prefer-std-map-try-emplace-over-insert
branch
from
1580e42 to
95fb45d
Compare
|
No Release Notes |
|
I have automatically backported this PR to "36-x-y", please check out #46794 |
trop
bot
added
in-flight/36-x-y
merged/36-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Small cleanup in our use of maps:
try_emplace()has more efficient move semantics and its name is clearer about what happens when the same key is already present in the map. All other things being equal, we should use it instead ofinsert().All human reviews welcomed! 😸 I'm also requesting a review from Copilot just to see what will happen; I've never used that before.
Checklist
npm testpassesRelease Notes
Notes: none.