feat(setup-elementor-env): allow enabling svg upload [ED-18594] #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to enable SVG uploads by introducing a new input parameter and updating WP options accordingly.
- Added a new boolean input "enable-svg-upload" in action metadata.
- Updated main.ts to incorporate the new WP option setting logic.
- Modified the workflow file to include the new input.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| actions/setup-elementor-env/main.ts | Updated input parsing and added logic for setting WP options based on the new flag. |
| .github/workflows/test-actions.yml | Included the new "enable-svg-upload" input in workflow configuration. |
| actions/setup-elementor-env/action.yml | Defined the new input "enable-svg-upload" with its default value and description. |
Files not reviewed (1)
- stubs/elementor-templates/test.json: Language not supported
| enable-svg-upload: | ||
| required: false | ||
| description: Whether to enable SVG and JSON uploads or not | ||
| default: 'false' |
There was a problem hiding this comment.
The default value is defined as a string while the code uses z.boolean() for parsing; this may lead to unexpected type conversion issues.
Suggested change
| default: 'false' | |
| default: false |
StyleShit
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.